Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): dynamic read request stall timeout #10958

Merged
merged 12 commits into from
Oct 14, 2024

Conversation

raj-prince
Copy link
Contributor

@raj-prince raj-prince commented Oct 7, 2024

  • Adding a new storage client option to enable pro-actively retry for stalled request based on dynamic timeout.
  • Added emulator test to validated the changes.

Copy link

conventional-commit-lint-gcf bot commented Oct 7, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 7, 2024
@raj-prince raj-prince marked this pull request as ready for review October 8, 2024 18:29
@raj-prince raj-prince requested review from a team as code owners October 8, 2024 18:29
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, a few more minor points.

storage/option.go Outdated Show resolved Hide resolved
storage/client_test.go Show resolved Hide resolved
storage/option.go Outdated Show resolved Hide resolved
storage/option.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more docs and defaults suggestions. Also, please follow #10984 to start an experimental package for the option.

storage/option.go Outdated Show resolved Hide resolved
storage/option.go Outdated Show resolved Hide resolved
storage/option.go Outdated Show resolved Hide resolved
@raj-prince raj-prince requested a review from tritone October 13, 2024 03:26
storage/option.go Outdated Show resolved Hide resolved
storage/option.go Outdated Show resolved Hide resolved
@raj-prince raj-prince requested a review from tritone October 14, 2024 01:05
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Oct 14, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit a09f00e into googleapis:main Oct 14, 2024
8 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants