Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner): support custom encoding and decoding of protos #10799

Merged

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented Aug 30, 2024

  • Proto messages and enum are converted to spanner supported PROTO and ENUM types.
  • However, there are cases where application uses the proto message and uses custom encoding to convert them to spanner supported types instead of converting it to default PROTO and ENUM types. This PR addresses this case which was earlier not happening.

Fixes #10662

@harshachinta harshachinta requested review from a team as code owners August 30, 2024 10:33
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Aug 30, 2024
@harshachinta harshachinta requested a review from rahul2393 August 30, 2024 10:42
@harshachinta harshachinta changed the title fix(spanner): add custom encoder decoder check for protos fix(spanner): support custom encoding and decoding of protos Aug 30, 2024
@harshachinta harshachinta enabled auto-merge (squash) September 2, 2024 10:47
@harshachinta harshachinta merged commit d410907 into googleapis:main Sep 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: encodeValue should prefer the Encoder interface before using generic proto serialization
2 participants