Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gir: Promisify class members in typescript generator #177

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ewlsh
Copy link
Collaborator

@ewlsh ewlsh commented Jul 17, 2024

First stab at fixing promisifying...

gi.ts exposes a function called promisifyFunctions which handles creating promisified versions of functions based on their signature. Eventually this should instead use the async annotations GLib is working to support.

Needs testing to ensure output is correct

@JumpLink
Copy link
Collaborator

JumpLink commented Jul 18, 2024

@ewlsh looks like there are new conflicts (see failed action), how are you handling conflicts so far?

A simple additional test could be to add another example that uses one of the async methods from the issue that did not work before. The GitHub action also validates the types of the examples

@JumpLink
Copy link
Collaborator

@ewlsh I have split ModuleGenerator, NpmPackage and TypeDefinitionGenerator into seperate files, this is the reason why you have a merge conflict. Do you want to fix it yourself or should I do it?

Fix merge conflict for gir: Promisify class members in typescript generator #177
swsnr added a commit to swsnr/gnome-shell-extension-picture-of-the-day that referenced this pull request Sep 7, 2024
swsnr added a commit to swsnr/gnome-shell-extension-picture-of-the-day that referenced this pull request Sep 7, 2024
swsnr added a commit to swsnr/gnome-shell-extension-picture-of-the-day that referenced this pull request Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants