Add tail_path option to in_tail plugin #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -252,6 +254,7 @@ def flush_buffer(tw) | |||
| else | |||
| @tag | |||
| end | |||
| record[@path_key] ||= tw.path unless @path_key.nil? | |||
There was a problem hiding this comment.
I mean that path_key is not overwritten if record already has it.
This was the specification of the original implementation (#281), but we can change the spec now. Do you prefer to overwrite?
There was a problem hiding this comment.
Either is fine for me.
BTW, user can check path_key value is not contained or not easily so
additional check is not needed for me.
There was a problem hiding this comment.
Okay, let us keep as is (not to overwrite).
|
Thx! |
repeatedly
added a commit
that referenced
this pull request
May 16, 2016
Add tail_path option to in_tail plugin
|
Tests added by this change in |
|
@tagomoris sorry, fixed the unstable test. |
cosmo0920
added a commit
to cosmo0920/fluent-plugin-tail_path
that referenced
this pull request
Dec 14, 2016
Because Fluentd v0.14 includes this feature. see: fluent/fluentd#951
cosmo0920
added a commit
to cosmo0920/fluentd-website
that referenced
this pull request
Feb 7, 2017
Because in_tail_path had been merged in in_tail in v0.14. ref: fluent/fluentd#945 ref: fluent/fluentd#951
cosmo0920
added a commit
to cosmo0920/fluentd-website
that referenced
this pull request
Feb 7, 2017
Because in_tail_path had been merged in in_tail in v0.12. ref: fluent/fluentd#945 ref: fluent/fluentd#951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #945