-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bermudan & Affine swaption submission #43
Conversation
Pull from eddelbuettel/rquntlib to tleitch
Merge branch 'master' of https://github.com/tleitch/rquantlib # Conflicts: # src/bermudan.cpp
Merge branch 'master' of https://github.com/tleitch/rquantlib # Conflicts: # R/affine.R # R/bermudan.R # src/affine.cpp
Eliminated all warnings. Code is set up to run base case in BermudanSwaption example. BermudanSwaption will take either market quotes or a DiscountCurve. AffineSwaption will only take a DiscountCurve. AffineSwaption will do a European swaption or Bermudan, but both are valued using an affine rate model that is fit to a vol curve. |
I only had a chance to glance at this so far but I haven't seen any reason not to merge.... |
Merged. We still need to fill in ChangeLog and inst/NEWS.Rd -- can you draft something (incl preferred email address for you) and just post it here? |
Will do. |
ChangeLog: 2016-05-09 Terry Leitch [email protected]
NEWS.Rmd: \section{Changes in RQuantLib version 0.4.3 (2016-06-30)}{ |
Thank you. From the look of it, you seem to have one more closing curly than opening. That would upset parsing, and I'll fold that in. Edit: I take that back. Three vs three. So maybe you committed against a non-current fork. I have idea, really. I am sure you figure it put. |
As for email, it is now jhu, it was uchicago before. Do you prefer one over the other? |
Yes, want to move to jhu email as it has better filters which is good when |
I'll update accordingly. |
Now committed in 0660070 |
Bermudan and Affine code and examples were rewritten. Search is limited to 5 market swaption vols for fit with the 1st swaption being the closest to the initial exercise date.