fix %in% and negative 'nanoperiod' parse. closes #96 #99 #100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the type on which
nanotime
is based frominteger64
tonumeric
does not solve the dispatch problems. It looks like there is a more fundamental dispatch issue in R when S3 methods are defined outside ofbase
.Here I have solved the issue by providing both S3 and S4 methods for
%in%
. Whenbit64
is not explicitly loaded and no S3 method exists, the S4 method is invoked. Afterbit64
is loaded the S3 method is invoked because if it is not present thebit64
S3 method will trump thenanotime
S4 method.Also fixed the parsing of a
nanoperiod
when it consists of only its negativenanoduration
part.