impl<T> Read for UniquePtr<T> where ... Pin<&a mut T> : Read
.
#1368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements forwarding of
Read
trait implementation fromUniquePtr<T>
to the pointee type. This is quite similar to howBox<T>
also forwards - seehttps://doc.rust-lang.org/std/boxed/struct.Box.html#impl-Read-for-Box%3CR%3E
Just as with
Box<T>
, theimpl
cannot be provided in the crate introducingT
, because this violates the orphan rule. This means that before this commit a wrapper newtype would be required to work around the orphan rule - e.g.:After this commit, one can provide an
impl
that works more directly with the C++ typeT
(the FFI will typically require passingself: Pin<&mut ffi::ReadTrait>
):For a more specific motivating example, please see: https://docs.google.com/document/d/1EPn1Ss-hfOC6Ki_B5CC6GA_UFnY3TmoDLCP2HjP7bms