Screen Reader Available Email label fields associated misattributed commits emails #16240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
commented
Mar 6, 2023
| @@ -38,6 +38,7 @@ | |||
| height: 10px; | |||
| // With width=100%, the icon will be centered horizontally | |||
| width: 100%; | |||
| vertical-align: unset; | |||
There was a problem hiding this comment.
Added this after taking windows screencast and seeing the warning icon out of place.
Before
After:
sergiou87
approved these changes
Mar 6, 2023
I am guessing it was on my recent PR that made the avatar a button when misattributed commit warning is present since it was |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/accessibility-audits/issues/3280
Description
This PR adds an
aria-labelto the other email input box in theGitpreferences/options. This adds a "Email" label to the select input of the misattribute popover.Screenshots
macOS
CleanShot.2023-03-02.at.12.19.12.mp4
Windows:
CleanShot.2023-03-06.at.07.22.03-trimmed.mp4
Release notes
Notes: [Improved] Other email input in "Git" preferences/Options and misattributed popover email select have a screen readable label.