-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watchtower HTTP API based updates #432
Conversation
6aeb925
to
ed9429a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is useful. Will also solve an issue I have with a container getting updated, while the UI tests are running!! Great 👍🏼
I think it is a good idea to Expose port 8080 from the Dockerfile, so that an update can be triggered by another running container, without necessarily need to bind a port to the host machine.
Auth should be added. |
@zoispag Just added the suggestions to the feature list. Thank you =) |
…ering via HTTP API
Even though this API presents a huge potential, I believe we've reached a minimal working version that can be improved by future PR's. Let me know if there should be something else implemented by now. |
Hi guys, great idea. I just wonder if you can add a rollback endpoint which should do a rollback in case the new image has issues (Yes it's possible ) I think here about 2 possible endpoints.
|
Thank you, Victor, for your excellent work! I'll have a look as soon as I can. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
So sorry for allowing this to fall between the cracks. Hope to get to it as soon as possible! Still feels like a great extension of watchtower in my opinion! |
Hi! I know this is a popular request but as we only track by hash on a tag, I really don’t see a feasible way of accomplishing this without having to add some kind of persisted memory to watchtower, which I’m kind of hesitant to do. If you have any suggestion on how this solution would work, feel free to open an issue for it and submit as much details as possible. With that said, at least to me, those endpoints are not within the scope of this particular pull request. Thanks for understanding! 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things, but other than that, I'd say this is pretty much good to go. Great work, @victorcmoura! I really appreciate you taking the time to push this change through. 🙏🏼
If you don't feel up for splitting out the API parts to a separate package at this point, just let me know and I'll add it to do the todo list. It's not critical, just something I think would be nice at some point down the line.
2a9577f
to
18c98bf
Compare
@simskij, just pushed the requested changes. xD |
That is awesome! Merging. Thanks again, @victorcmoura! |
@all-contributors add @victorcmoura for code and docs |
I've put up a pull request to add @victorcmoura! 🎉 |
This pull request implements the changes proposed in #429.
API Features + ToDo List:
--http-api-port flag to customize the listening port(Container will always listen to 8080)Required changes:
Suggestions are welcomed!