Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leader epoch to control messages #4434

Merged
merged 5 commits into from
Sep 29, 2023

Conversation

emasab
Copy link
Collaborator

@emasab emasab commented Sep 14, 2023

to make sure they're stored for committing even without a subsequent fetch message

See #4384.

@emasab emasab force-pushed the dev_fix_leader_epoch_in_control_messages branch 2 times, most recently from 5806fd6 to b6e572e Compare September 20, 2023 08:43
to make sure they're stored for committing
even without a subsequent fetch message
@emasab emasab force-pushed the dev_fix_leader_epoch_in_control_messages branch from b6e572e to 9c44d55 Compare September 20, 2023 08:45
@emasab emasab marked this pull request as ready for review September 20, 2023 08:55
@milindl milindl self-requested a review September 26, 2023 04:57
Copy link
Contributor

@milindl milindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, great PR

tests/0103-transactions.c Outdated Show resolved Hide resolved
@emasab emasab merged commit 9be261b into master Sep 29, 2023
2 checks passed
@emasab emasab deleted the dev_fix_leader_epoch_in_control_messages branch September 29, 2023 06:33
axelandersson added a commit to axelandersson/librdkafka that referenced this pull request Oct 5, 2023
* upstream/master:
  librdkafka v2.3.0 (confluentinc#4455)
  Fix for idempotent producer fatal errors, triggered after a possibly persisted message state (confluentinc#4438)
  Move can_q_contain_fetched_msgs inside q_serve (confluentinc#4431)
  [KIP-580] Exponential Backoff with Mock Broker Changes to Automate Testing. (confluentinc#4422)
  Update only the mklove version of OpenSSL to 3.0.11 (confluentinc#4454)
  Permanent errors during offset validation should be retried (confluentinc#4447)
  Increased flexver request size for Metadata request to include topic_id size (confluentinc#4453)
  Fix loop of OffsetForLeaderEpoch requests on quick leader changes (confluentinc#4433)
  Fix for stored offsets not being committed if they lacked the leader epoch (confluentinc#4442)
  Add leader epoch to control messages (confluentinc#4434)
  Refactored tmpabuf and fixed an insufficient buffer allocation (confluentinc#4449)
  Work around KIP-700 restrictions for DescribeCluster [KIP-430]
  [admin] KIP-430: Add authorized operations to describe API
  Fix segfault if assignor state is NULL, (confluentinc#4381)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants