fix: Add quay back to authn config #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could add a test pull to fetch.bzl so that this is caught next time? |
|
Do you have an example of a test that tests auth. I'd be happy to add a test that uses authentication. There's already a test that pulls in a quay repo, but in order to test this we'd need something with authentication. |
|
Oh i didn't realize we had it. Unfortunately we don't have a test suite that ensures private images are accessible. |
|
This needs a rebase. |
|
rebase is done, can we merge then? |
thesayyn
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the quay config got lost when refactoring
pull.bzltoauthn.bzlthis PR adds it back