Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk export #103

Closed
wants to merge 2 commits into from
Closed

Bulk export #103

wants to merge 2 commits into from

Conversation

askeron
Copy link

@askeron askeron commented Aug 30, 2020

This adds buttons to bulk export all chats at once. (see issue #36 )
Disclamer: This is not my code, I found this commit in the fork of zmeyc. I just also need this functionality.

@andreas-mausch
Copy link
Owner

Wow thanks. Have you tested it and verified its functional?

I really need to set up my dev environment again..

One thing I've noticed on the first look: it seems to replace the old buttons, right? I'd prefer if it would add new buttons instead

@askeron
Copy link
Author

askeron commented Aug 30, 2020

Sadly, no. I'm a developer, but I do mostly Java, Kotlin and NodeJS. The last time I wrote C and C++ was in collage. I tried to compile your code with Visual Studio 2019, but failed because there seems to be several thing that still link to Visual Studio 2017 and 2010. (At least the error messages indicated this.) And I got this error with your code independently from the new code, so that I assume it is only because of my building environment.
But I looked through the diffs and I am understanding most of the changes. They seem legit and as I understand the diff, he did not remove the single export buttons but added additional buttons for bulk export. He only refactored the buttons so that both buttons could use the same subfuction.

@andreas-mausch andreas-mausch added this to the v1.14 milestone Sep 20, 2020
@andreas-mausch
Copy link
Owner

Hi @askeron,

I've merged the changes on command-line and resolved the conflicts with the newest master.
However, github now doesn't recognize the changes are already in master, and your name doesn't appear in the git log.
I'm sorry about that. :(
(If you know how to fix it, please let me know)

Everything worked without any changes, so thank you very much for the contribution.

andreas-mausch added a commit that referenced this pull request May 9, 2021
@andreas-mausch andreas-mausch modified the milestones: v1.15, v1.14 May 9, 2021
@askeron
Copy link
Author

askeron commented May 9, 2021

That's fine for me. The important things is that it made it in the master.

@askeron askeron closed this May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants