Fix tests on nightly #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's fine, as long as it's readable I don't care. It seems like this is failing the |
|
I intended to make it work on both nightly and stable; the issue is just a new IOErrorKind that is only emitted on nightly, but tests need to check for it. I will fix. |
|
Looks like that new kind has leaked into stable. This is an API break IMO. :/ |
4 tasks
Nightly has richer IO error kinds, and the meaning of ErrorKind::Other has been changed, so we cannot use that anymore. Instead use raw OS errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly has richer IO error kinds
Sorry about the extensive reformatting of the yml... editors and we haven't dropped a common config file :/