Added tooltip option to Tabs macro #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tooltips should be entered in the 'tooltip' field of each tab tiddler
|
In this version -- 'currentTiddler' is set to the value of 'currentTab' only around the $button widget. Hopefully this will not interfere with anything else (appears to be no problems.) |
|
This seems to break the "default" tab -- but I can't see why. Any ideas? Specifically -- the default is broken only for subsequent calls of the tabs macro (as for the examples) -- the first call in any tiddler functions correctly. |
|
OK -- after cleaning all of the state tiddlers, now functions correctly -- seems to have been caused by 'dirty' leftover state tiddlers. |
What do you think of this idea?
|
Thanks @matabele |
Jermolene
added a commit
that referenced
this pull request
Dec 24, 2015
Added tooltip option to Tabs macro
Jermolene
added a commit
that referenced
this pull request
Jan 7, 2016
The problem is that this change scrambles the ordering of tabs that use programmatic ordering, for example here: https://github.com/Jermolene/TiddlyWiki5/blob/master/editions/tw5.com/ti ddlers/releasenotes/TiddlyWiki_Releases.tid#L13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltips should be entered in the 'tooltip' field of each tab tiddler