Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update format string in test package by updating generated RcppExports file #1289

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

eddelbuettel
Copy link
Member

@eddelbuettel eddelbuettel commented Nov 28, 2023

@kalibera found another format string in need of an update, this time in an embedded source package used by tinytest, and very kindly emailed a diff.

The fix was actually even more trivial thanks to #1288 as it needed simply an call of compileAttributes() with the update source package from #1288. This also updates two other minor aspects in the generated code we had addressed since the test example was first created.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel eddelbuettel merged commit 4a8d30f into master Nov 28, 2023
14 checks passed
@eddelbuettel eddelbuettel deleted the bugfix/format_string_in_testfile branch November 28, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants