Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct request formation as identified in #393 #394

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

eddelbuettel
Copy link
Member

As identified by @mtkerbeR in #393, there was a Name{} invocation too many which bricked bds(). This restores it.

Many thanks to @mtkerbeR for catching this and the patient testing.

@mtkerbeR
Copy link
Contributor

mtkerbeR commented Sep 1, 2024

I think line 271 has to be adjusted as well, as it is still sufferign from the same problem - namely a Name{} within appendValue()

request.getElement(Name{"fields"}).appendValue(Name{field.c_str()});

@eddelbuettel
Copy link
Member Author

And lines 314 and 316.

@mtkerbeR
Copy link
Contributor

mtkerbeR commented Sep 1, 2024

Just to confirm: After adjusting lines 314 and 316, function getPorfolio() works as expected as well.
I think there is no test case for this function as the portfolio IDs used as a paramter are client specific, i.e. cannot be tested by people not within the same organization.

@eddelbuettel eddelbuettel mentioned this pull request Sep 2, 2024
7 tasks
@johnlaing johnlaing merged commit 882e546 into master Sep 5, 2024
2 checks passed
@eddelbuettel eddelbuettel deleted the bugfix/bds branch September 5, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants