Avoid deprecation warnings over char* instead of Name #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes now-outdated hard-wiring of C++11 as a compilation standard and adds an .editorconfig file
|
I suggest we merge this one first -- and I then rebase the other branch (which just successfully ran under CI for both macOS (now arm64 at GitHub) and Linux) and create a PR off it. It uses a branch at the |
johnlaing
reviewed
Aug 26, 2024
src/bdh.cpp
Outdated
| // Copyright (C) 2013 Whit Armstrong | ||
| // Copyright (C) 2015 Whit Armstrong and Dirk Eddelbuettel | ||
| // Copyright (C) 2013 Whit Armstrong | ||
| // Copyright (C) 2015-204 Whit Armstrong and Dirk Eddelbuettel |
There was a problem hiding this comment.
Yup. Will fix.
Done in b89177f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes now-outdated hard-wiring of C++11 as a compilation standard and adds an .editorconfig file.
The library update (via an update to the blp repo) will follow.