Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: brace expansion #729

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Fix: brace expansion #729

merged 1 commit into from
Jul 29, 2022

Conversation

t-mat
Copy link
Contributor

@t-mat t-mat commented Jul 29, 2022

Currently, make trailingWhitespace fails with the following error (but ! passes it).

$ make trailingWhitespace
! grep -E "`printf '[ \\t]$'`" cli/*.{c,h,1} *.c *.h LICENSE Makefile cmake_unofficial/CMakeLists.txt
grep: cli/*.{c,h,1}: No such file or directory

This error is caused by cli/*.{c,h,1}, because GNU make invokes shell which doesn't support brace expansion.

This PR fixes it with plain wildcards.

@t-mat
Fix: brace expansion
051276a 
Since GNU make invokes `shell` by default, it doesn't support brace expansion.
This changeset expands the braces to fix the issue.
@Cyan4973
Copy link
Owner

Great find ! Thanks for fixing this issue @t-mat !

@Cyan4973 Cyan4973 merged commit 1dc8eb9 into Cyan4973:dev Jul 29, 2022
@t-mat t-mat deleted the fix-makefile-glob branch July 29, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cyan4973 Cyan4973 Cyan4973 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-mat @Cyan4973