Properly fix altivec namespace collisions #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @pkubaj |
Uses `#pragma push_macro`/`#pragma pop_macro` instead of assuming that `__APPLE_ALTIVEC__` can be defined safely. Safer and less hacky fix for Cyan4973#668.
ba52731
to
ec4030d
Compare
|
Yes, that works as well, thanks! |
|
minor concern : |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Jan 4, 2022
In file included from /wrkdirs/usr/ports/lang/php81/work/php-8.1.1/ext/hash/hash_xxhash.c:18:
In file included from ext/hash/php_hash_xxhash.h:21:
In file included from /wrkdirs/usr/ports/lang/php81/work/php-8.1.1/ext/hash/xxhash/xxhash.h:2412:
/usr/lib/clang/11.0.1/include/altivec.h:55:19: error: unknown type name 'vector'
static __inline__ vector bool char __ATTRS_o_ai
^
/usr/lib/clang/11.0.1/include/altivec.h:56:10: error: unknown type name 'vector'
vec_perm(vector bool char __a, vector bool char __b, vector unsigned char __c);
^
/usr/lib/clang/11.0.1/include/altivec.h:56:32: error: unknown type name 'vector'
vec_perm(vector bool char __a, vector bool char __b, vector unsigned char __c);
^
/usr/lib/clang/11.0.1/include/altivec.h:66:19: error: unknown type name 'vector'
static __inline__ vector bool short __ATTRS_o_ai vec_perm(
Patch from Cyan4973/xxHash#672
Because the VSX path is only enabled on GCC compatible compilers. |
Cyan4973
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
#pragma push_macro/#pragma pop_macroinstead of assuming that__APPLE_ALTIVEC__can be defined safely.Safer and less hacky fix for #668.