Bug 93733 - MISSING tests still write out their results file
Summary: MISSING tests still write out their results file
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: NRWT
Depends on:
Blocks:
 
Reported: 2012-08-10 11:46 PDT by Ojan Vafai
Modified: 2012-09-13 17:20 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-08-10 11:46:06 PDT 
This is arguable, but if a test is expected to be MISSING, I don't think it should write out the actual results file the way we do for new tests. As it is right now, I end up with junk in my LayoutTests directory every time I run the tests because some tests are listed as MISSING.
Comment 1 Dirk Pranke 2012-08-10 11:49:50 PDT 
the only thing that makes me waffle a bit on this is when we have bugs that cause dumpAsText() to not be called and we report MISSING because we don't find a matching png ... the results are a pretty good clue that something's wrong here.
Comment 2 Dirk Pranke 2012-08-10 11:50:26 PDT 
but we could probably address that differently ... see https://bugs.webkit.org/show_bug.cgi?id=63104 .
Comment 3 Ojan Vafai 2012-08-10 11:53:17 PDT 
Not sure how that's related. This would only affect files listed in TestExpectations as MISSING. The main use-case for writing out the results is for new tests that people write, which obviously wouldn't have a MISSING entry in TestExpectations.
Comment 4 Dirk Pranke 2012-08-10 11:57:02 PDT 
oh, I see. expected missing vs. unexpected missing ...
Comment 5 Ojan Vafai 2012-08-10 12:03:21 PDT 
Right.
Comment 6 Ojan Vafai 2012-09-13 17:20:28 PDT 
We'll be getting rid of MISSING soon in the great layout test refactor. So, this doesn't seem worth fixing. I looked into it and it requires a good deal of plumbing and/or hackery.