To reproduce: 1. new-run-webkit-tests All tests "crash". In fact DRT is failing to launch.
<rdar://problem/10638124>
Looks like we need to set PATH correctly, like ORWT does. There's even a comment about this in port/win.py!
I think we'll also need a way to read strings from the registry, and to convert from Windows paths to Cygwin paths. (webkitpy.common.system.path.cygpath goes in the other direction.)
Maybe it would be better to fix this by making DRT/WTR not require any special PATH munging at all, like we plan to do for MiniBrowser (bug 68576) and WinLauncher (bug 68578).
(In reply to comment #3) > I think we'll also need a way to read strings from the registry, and to convert from Windows paths to Cygwin paths. (webkitpy.common.system.path.cygpath goes in the other direction.) Can we get this w/ path._winpath_to_uri and then strip off the 'file:///', or do we need more cygpath magic?
(In reply to comment #5) > (In reply to comment #3) > > I think we'll also need a way to read strings from the registry, and to convert from Windows paths to Cygwin paths. (webkitpy.common.system.path.cygpath goes in the other direction.) > > Can we get this w/ path._winpath_to_uri and then strip off the 'file:///', or do we need more cygpath magic? We need more cygpath magic. We need to turn something like this: C:\Program Files (x86)\Common Files\Apple\Apple Application Support into this: /cygdrive/c/Program Files (x86)/Common Files/Apple/Apple Application Support But I'm going to make DRT/WTR not require all this PATH magic, which will mean we won't need a way to read from the registry or convert to Cygwin paths at all.
This affects WebKitTestRunner too.
Created attachment 121277 [details] Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
Created attachment 121281 [details] Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
Thanks adam. :)
Committed r104188: <http://trac.webkit.org/changeset/104188>