Created attachment 60392 [details] test case When the attached test case in printed in Safari, the text 'THIS TEXT DISAPPEARS WHEN PRINTED.' is not included in the output. Instead, three blank pages are printed.
<rdar://problem/8129536>
page-break-inside:avoid was implemented in <http://trac.webkit.org/changeset/54929>.
Created attachment 60398 [details] test case Simplified the original test case by removing the table.
The test case as-is doesn’t reproduce for me unless I resize the window vertically smaller until there is a vertical scrollbar.
Ah, the new one doesn’t have that problem!
Created attachment 60416 [details] test case Using percentages for block heights.
The original change should be rolled out. What's checked in does more harm than good in its present state.
Okay. It might be better to revert the original change. I'll revert it. (In reply to comment #7) > The original change should be rolled out. What's checked in does more harm than good in its present state.
Created attachment 60506 [details] rolling-out-page-break-inside-avoid
Comment on attachment 60506 [details] rolling-out-page-break-inside-avoid Rejecting patch 60506 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: tree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found Testing 19289 test cases. fast/multicol/break-properties.html -> failed Exiting early after 1 failures. 14313 tests run. 213.95s total testing time 14312 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3382320
Created attachment 60581 [details] rolling-out-page-break-inside-avoid-fix-expected
I've fixed the expected result of fast/multicol/break-properties.html, which is also expected to fail. (In reply to comment #11) > Created an attachment (id=60581) [details] > rolling-out-page-break-inside-avoid-fix-expected
Comment on attachment 60581 [details] rolling-out-page-break-inside-avoid-fix-expected Clearing flags on attachment: 60581 Committed r62632: <http://trac.webkit.org/changeset/62632>
All reviewed patches have been landed. Closing bug.
http://trac.webkit.org/changeset/62632 might have broken GTK Linux 32-bit Release and Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/62632 http://trac.webkit.org/changeset/62633