Bug 40535 - [Qt] GraphicsLayer: recaching images creates an unnecessary deep copy
Summary: [Qt] GraphicsLayer: recaching images creates an unnecessary deep copy
Status: CLOSED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords: Performance, Qt
Depends on:
Blocks: 38744
  Show dependency tree / graph
 
Reported: 2010-06-12 20:19 PDT by Noam Rosenthal
Modified: 2010-06-13 14:11 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2010-06-12 20:22 PDT, Noam Rosenthal 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2010-06-12 20:19:21 PDT 
Profiling on Mac with raster + QGLWidget shows repeating image copies.
Comment 1 Noam Rosenthal 2010-06-12 20:22:53 PDT 
Created attachment 58575 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-12 20:35:54 PDT 
Comment on attachment 58575 [details]
Patch

OK.  rs=me.
Comment 3 WebKit Commit Bot 2010-06-13 01:20:32 PDT 
Comment on attachment 58575 [details]
Patch

Clearing flags on attachment: 58575

Committed r61086: <http://trac.webkit.org/changeset/61086>
Comment 4 WebKit Commit Bot 2010-06-13 01:20:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Simon Hausmann 2010-06-13 14:10:47 PDT 
Revision r61086 cherry-picked into qtwebkit-2.0 with commit 661d414dc93f5f57352dbfd1600a67d5d5407b21