Bug 15244 - <td> renders too wide causing a layout issue
Summary: <td> renders too wide causing a layout issue
Status: RESOLVED WORKSFORME
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 523.x (Safari 3)
Hardware: All All
: P2 Normal
Assignee: gur.trio
URL: http://www.freeflashintros.com/
Keywords: HasReduction
Depends on:
Blocks: 15273
  Show dependency treegraph
 
Reported: 2007-09-20 08:27 PDT by Anantha Keesara
Modified: 2014-03-09 22:51 PDT (History)
10 users (show)

See Also:


Attachments
<td> render big and cause layout issue. (647 bytes, text/html)
2007-09-20 08:29 PDT, Anantha Keesara
no flags Details
Patch (37.35 KB, patch)
2014-03-05 05:55 PST, gur.trio
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anantha Keesara 2007-09-20 08:27:50 PDT
Steps:
1. load http://www.freeflashintros.com/ to see the layout issue.

Other browsers: 
IE,FF,Opera gets it right.

Safari has issue.
Comment 1 Anantha Keesara 2007-09-20 08:29:29 PDT
Created attachment 16334 [details]
<td> render big and cause layout issue.
Comment 2 David Kilzer (:ddkilzer) 2007-09-20 08:57:02 PDT
Confirmed with a local debug build of WebKit r25670 using Safari 3 Public Beta v. 3.0.3 (522.12.1) on Mac OS X 10.4.10.

This is not a regression as shipping Safari 2.0.4 (419.3) with original WebKit on 10.4.10 behaves the same way.

Comment 3 gur.trio 2014-03-05 05:55:37 PST
Created attachment 225877 [details]
Patch
Comment 4 gur.trio 2014-03-06 04:47:36 PST
(In reply to comment #3)
> Created an attachment (id=225877) [details]
> Patch

Please review. Thanks.
Comment 5 zalan 2014-03-06 08:01:54 PST
Comment on attachment 225877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=225877&action=review

> Source/WebCore/ChangeLog:3
> +        <td> renders too wide causing a layout issue

I can't reproduce the original bug (tested the reduced case). <td> sizing looks correct to me and we distribute the available space similar to FF. Since your patch does not alter layout (as all it does is skip border painting), I doubt this would fix this problem even if it was still reproducible. Our current border painting behavior is clearly different from FF, but that has not much to do with this bug.
Comment 6 gur.trio 2014-03-07 01:12:02 PST
(In reply to comment #5)
> (From update of attachment 225877 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=225877&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        <td> renders too wide causing a layout issue
> 
> I can't reproduce the original bug (tested the reduced case). <td> sizing looks correct to me and we distribute the available space similar to FF. Since your patch does not alter layout (as all it does is skip border painting), I doubt this would fix this problem even if it was still reproducible. Our current border painting behavior is clearly different from FF, but that has not much to do with this bug.

Hi Zalan you are right. Actually I got confused and thought it is the border issue. As this bug https://bugs.webkit.org/show_bug.cgi?id=15273 says that 15244 is the dupe of 15273 so I thought maybe its the border issue. 
Since the issue is not reproducible so shall I edit the bug description and make it similiar to 15273 or close this and add this patch to https://bugs.webkit.org/show_bug.cgi?id=15273.
Please suggest.
Comment 7 zalan 2014-03-07 07:50:10 PST
(In reply to comment #6)
> (In reply to comment #5)
> > (From update of attachment 225877 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=225877&action=review
> > 
> > > Source/WebCore/ChangeLog:3
> > > +        <td> renders too wide causing a layout issue
> > 
> > I can't reproduce the original bug (tested the reduced case). <td> sizing looks correct to me and we distribute the available space similar to FF. Since your patch does not alter layout (as all it does is skip border painting), I doubt this would fix this problem even if it was still reproducible. Our current border painting behavior is clearly different from FF, but that has not much to do with this bug.
> 
> Hi Zalan you are right. Actually I got confused and thought it is the border issue. As this bug https://bugs.webkit.org/show_bug.cgi?id=15273 says that 15244 is the dupe of 15273 so I thought maybe its the border issue. 
> Since the issue is not reproducible so shall I edit the bug description and make it similiar to 15273 or close this and add this patch to https://bugs.webkit.org/show_bug.cgi?id=15273.
> Please suggest.
Close this as worksforme and go ahead with bug 15273.
Comment 8 gur.trio 2014-03-09 22:51:38 PDT
Issue is not reproducible on latest webkit. No need for patch so closing the issue.