Bug 144586 - Make ExecState::vm() branchless in release builds.
Summary: Make ExecState::vm() branchless in release builds.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Performance
Depends on:
Blocks:
 
Reported: 2015-05-04 10:31 PDT by Andreas Kling
Modified: 2015-05-04 11:47 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.25 KB, patch)
2015-05-04 10:31 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2015-05-04 10:31:17 PDT 
ExecState::vm() is currently implemented as ExecState::callee()->vm(), which is sad because callee() does a null check.
Comment 1 Andreas Kling 2015-05-04 10:31:50 PDT 
Created attachment 252320 [details]
Patch
Comment 2 Geoffrey Garen 2015-05-04 10:47:23 PDT 
Comment on attachment 252320 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2015-05-04 11:46:59 PDT 
Comment on attachment 252320 [details]
Patch

Clearing flags on attachment: 252320

Committed r183753: <http://trac.webkit.org/changeset/183753>
Comment 4 WebKit Commit Bot 2015-05-04 11:47:03 PDT 
All reviewed patches have been landed.  Closing bug.