This vote passes with the following result: +1: Bruno Kinoshita (binding) +1: Gary Gregory (binding) +1: Tomas Lanik +1: Gilles Sadowski (binding) +1: Alex Herbert (binding)
Thanks to everyone who voted. Alex On Mon, 12 Aug 2024 at 10:27, Alex Herbert <[email protected]> wrote: > > My +1. > > Alex > > On Sat, 10 Aug 2024 at 01:25, Gilles Sadowski <[email protected]> wrote: > > > > Hi. > > > > $ git clone https://gitbox.apache.org/repos/asf/commons-numbers.git > > --branch commons-numbers-1.2-RC1 commons-numbers-1.2-RC1 > > $ cd commons-numbers-1.2-RC1 > > $ git tag -v commons-numbers-1.2-RC1 > > -> OK > > > > $ mvn clean package site site:stage -Pexamples > > -> OK > > > > $ mvn -v > > Apache Maven 3.6.3 > > Maven home: /usr/share/maven > > Java version: 11.0.23, vendor: Debian, runtime: > > /usr/lib/jvm/java-11-openjdk-amd64 > > Default locale: en_US, platform encoding: UTF-8 > > OS name: "linux", version: "5.10.0-23-amd64", arch: "amd64", family: "unix" > > > > > [...] > > > > > > These are the artifacts and their hashes: > > > > > > #Release SHA-512s > > > #Thu Aug 08 15:30:08 BST 2024 > > > commons-numbers-1.2-bin.tar.gz=b97c0ca2df1796c1ff8932134edb16c5156198900ec23623ad6ff99080ce7f44603a8bc1ab488234ec9761f650a6f628aece582cfae31c97e9cec110f7fe298f > > > commons-numbers-1.2-bin.zip=bab72867ab6ea80e68ea8d0880278cae210fbda48f1d92a83dc06481410662b0d90b51fa2411cf5faf4bcbab52e2d7578b13c968e344d060f9902d90ee1f2270 > > > commons-numbers-1.2-src.tar.gz=f1cd6e0b70497977549d881a26aeb96cb4ff2cd3500290498d279ee6425b82ca681216353b5461df33df46d4fef7e766f983fa41a739dbd4bd77da71b42509be > > > commons-numbers-1.2-src.zip=f0faee4a26ed692a15f02cca2d5a2224047cb7c404dcef35f832346cf101ebdb4f25e9efec2333a70c1718b6750942c1db6bb5d71082a1288a8ce38a2f357562 > > > > I still don't get why the (generated ?) message puts the hashes in the above > > format while the "sha512sum" command-line tool would need the following: > > $ cat hash.txt > > b97c0ca2df1796c1ff8932134edb16c5156198900ec23623ad6ff99080ce7f44603a8bc1ab488234ec9761f650a6f628aece582cfae31c97e9cec110f7fe298f > > binaries/commons-numbers-1.2-bin.tar.gz > > bab72867ab6ea80e68ea8d0880278cae210fbda48f1d92a83dc06481410662b0d90b51fa2411cf5faf4bcbab52e2d7578b13c968e344d060f9902d90ee1f2270 > > binaries/commons-numbers-1.2-bin.zip > > f1cd6e0b70497977549d881a26aeb96cb4ff2cd3500290498d279ee6425b82ca681216353b5461df33df46d4fef7e766f983fa41a739dbd4bd77da71b42509be > > source/commons-numbers-1.2-src.tar.gz > > f0faee4a26ed692a15f02cca2d5a2224047cb7c404dcef35f832346cf101ebdb4f25e9efec2333a70c1718b6750942c1db6bb5d71082a1288a8ce38a2f357562 > > source/commons-numbers-1.2-src.zip > > $ sha512sum -c hash.txt > > binaries/commons-numbers-1.2-bin.tar.gz: OK > > binaries/commons-numbers-1.2-bin.zip: OK > > source/commons-numbers-1.2-src.tar.gz: OK > > source/commons-numbers-1.2-src.zip: OK > > > > Is the purpose of the "signature-validator.sh" script (present in the > > "dist" directory) to also check the artefacts on the Nexus server? > > [I don't know how to do that...] > > > > > > > > I have tested this with 'mvn clean install' and > > > 'mvn clean package site site:stage -Pexamples' using: > > > > > > Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae) > > > Maven home: /Users/ah403/software/apache-maven-3 > > > Java version: 11.0.23, vendor: Eclipse Adoptium, runtime: > > > /Library/Java/JavaVirtualMachines/temurin-11.jdk/Contents/Home > > > Default locale: en_GB, platform encoding: UTF-8 > > > OS name: "mac os x", version: "14.6", arch: "aarch64", family: "mac" > > > > > > Note: The examples require Java 9+. > > > > > > Details of changes since 1.1 are in the release notes: > > > > > > https://dist.apache.org/repos/dist/dev/commons/numbers/1.2-RC1/RELEASE-NOTES.txt > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/changes-report.html > > > > > > Site (the multi-module site has been staged on an Apache user home site): > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/ > > > (note some *relative* links are broken and the 1.2 directories are > > > not yet created - these will be OK once the site is deployed.) > > > > > > JApiCmp Report: > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/commons-numbers-angle/japicmp.html > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/commons-numbers-arrays/japicmp.html > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/commons-numbers-combinatorics/japicmp.html > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/commons-numbers-complex/japicmp.html > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/commons-numbers-core/japicmp.html > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/commons-numbers-field/japicmp.html > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/commons-numbers-fraction/japicmp.html > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/commons-numbers-gamma/japicmp.html > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/commons-numbers-primes/japicmp.html > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/commons-numbers-quaternion/japicmp.html > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/commons-numbers-rootfinder/japicmp.html > > > > [I did not check those, assuming that the build should fail in case of > > an incompatible > > API change.] > > > > > > > > RAT Report: > > > > > > https://home.apache.org/~aherbert/commons-numbers-1.2-RC1-site/rat-report.html > > > > [Ditto.] > > > > > > > > KEYS: > > > https://downloads.apache.org/commons/KEYS > > > > > > Please review the release candidate and vote. > > > > I also checked that the build of "Commons Math" using the latest "Commons > > Numbers" (v1.2-SNAPSHOT) and "Commons RNG" (v1.6) is successful. > > > > > This vote will close no sooner than 72 hours from now. > > > > > [X] +1 Release these artifacts > > > [ ] +0 OK, but... > > > [ ] -0 OK, but really should fix... > > > [ ] -1 I oppose this release because... > > > > > > > Thanks, > > Gilles > > > > > [...] > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
