Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not modify constructor options argument #974

Merged

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Jan 7, 2020

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #971

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2020
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #974 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #974      +/-   ##
=========================================
+ Coverage      99%     99%   +<.01%     
=========================================
  Files          11      11              
  Lines       10657   10659       +2     
  Branches      473     473              
=========================================
+ Hits        10551   10553       +2     
  Misses        106     106
Impacted Files Coverage Δ
src/storage.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 388e32d...13ca737. Read the comment docs.

@stephenplusplus stephenplusplus merged commit 4969148 into googleapis:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constructor should not modify its options argument
3 participants