fix: add createBucket file and updated relevant test

[sofisl]

Fix: internal reference b/144088253

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

[sofisl]

@fhinkel - I'm not sure why the build test isn't passing. It seems to be an issue with the storage.ts test under system-test, but I didn't touch that test, and confirmed that it's up-to-date with the master branch. Not sure if I'm missing something or if it's a bug...

[fhinkel]

@sofisl I don't see right away why the system test is failing. But there are hundreds of tests, I wonder if the new test is somehow messing with the system tests, because it is creating a bucket and not deleting it.

Can you delete the existing createBucket code and test in the sample. And we should change the new test to delete the bucket at the end of the test run. Otherwise we're left with a bucket after running the test once.

[bcoe]

@sofisl @fhinkel I have a hunch that this is a flaky test, just kicked off the build to hopefully confirm.

[codecov]

Codecov Report

Merging #940 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #940   +/-   ##
=======================================
  Coverage   95.41%   95.41%           
=======================================
  Files          11       11           
  Lines        1242     1242           
  Branches      309      309           
=======================================
  Hits         1185     1185           
  Misses         29       29           
  Partials       28       28

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fea60c...a17b926. Read the comment docs.

[fhinkel]

Don't we need to delete the existing createBucket sample? I only see code additions.

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

[sofisl]

@fhinkel - I think the system test is still flaky, this is the error - https://screenshot.googleplex.com/MZ27aYXMaeD

Otherwise all the tests have passed

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

[bcoe]

This looks great to me, we should update existing samples in cloud.google.com referencing the old file, however, before we land.

Please feel free to loop me in on that review.

[sofisl]

@fhinkel - waiting on CL to be approved to merge cl 284587412

[fhinkel]

@sofisl Sorry I didn't see this. Always better to ping me on chat rather than relying on GitHub notifications. LGTM! Thanks