Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove compodoc dev dependency #1745

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners January 10, 2022 17:58
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Jan 10, 2022
@ddelgrosso1
Copy link
Contributor Author

This dependency was/is breaking CI builds for Node 15 due to only supporting 12, 14, 16.

@shaffeeullah
Copy link
Contributor

Is it not necessary?

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@ddelgrosso1
Copy link
Contributor Author

@shaffeeullah that is what I was trying to see by removing it and running everything through CI. It was brought in as part of the GCS Resumable move but not sure what it was doing there or if we need it here.

@ddelgrosso1
Copy link
Contributor Author

This was used in the gcs-resumable-upload library to generate the documentation. It is not needed here as we are not publicly exposing those interfaces through storage but rather just consuming the code that was internalized here. I feel comfortable that this can be safely removed.

@ddelgrosso1 ddelgrosso1 merged commit 809bf11 into googleapis:main Jan 10, 2022
@ddelgrosso1 ddelgrosso1 deleted the remove-compdoc branch January 10, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants