Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix logic for buckets that do not have a generation #1634

Merged
merged 2 commits into from
Oct 1, 2021
Merged

fix: fix logic for buckets that do not have a generation #1634

merged 2 commits into from
Oct 1, 2021

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team as code owners October 1, 2021 18:18
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Oct 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2021
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2021
shaffeeullah
shaffeeullah approved these changes Oct 1, 2021
View reviewed changes
test/bucket.ts Show resolved Hide resolved
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2021
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 1, 2021
@shaffeeullah shaffeeullah merged commit 9069bdc into googleapis:main Oct 1, 2021
ddelgrosso1 added a commit to ddelgrosso1/nodejs-storage that referenced this pull request Oct 4, 2021
@ddelgrosso1
fix: fix logic for buckets that do not have a generation (googleapis#…
3341402 
…1634)

* fix: fix logic for buckets that do not have a generation

* add test for autoRetry remaining true
ddelgrosso1 added a commit that referenced this pull request Oct 4, 2021
@ddelgrosso1
fix: fix logic for buckets that do not have a generation (#1634)
a3dafb9 
* fix: fix logic for buckets that do not have a generation

* add test for autoRetry remaining true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaffeeullah shaffeeullah shaffeeullah approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ddelgrosso1 @shaffeeullah