feat: customize retry behavior implementation (#1474) #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: customize retry behavior implementation * 🦉 Updates from OwlBot * fixed != * 🦉 Updates from OwlBot * updated names to match gogle gax * 🦉 Updates from OwlBot * refactored retryOptions into its own config * 🦉 Updates from OwlBot * fixed linting error * 🦉 Updates from OwlBot * added retry delay explanation * 🦉 Updates from OwlBot * refactored constants * 🦉 Updates from OwlBot * removed const assignment Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* implemented retry function * 🦉 Updates from OwlBot * fixed import * 🦉 Updates from OwlBot * resolved merge conflict * passed retry function to common * 🦉 Updates from OwlBot * refactored code to retryableErrFn * removed unused import * fixed typo * fixed typo * fixed failing tests * made retryableErrorFn configurable * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * wrote unit tests * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * changed reason check to be less brittle * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* feat: remove gaxios dependency * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * moved callbackFunction inline * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * assigned types to any * changed any to string Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* feat: applied customization to multipart filesave * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * fixed failing tests * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md * removed unused import Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
danielduhh
reviewed
Jul 15, 2021
danielduhh
reviewed
Jul 15, 2021
added comment next to EAI_AGAIN
* feat: pass retryOptions to gcs-resumable-upload * linter fixes * additional test assertions for retryOptions * add additional asserts to resumable operation tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry customization implementation.
Adds the RetryOptions interface which allows users to configure retryDelayMultiplier, totalTimeout, maxRetryDelay, autoRetry, maxRetries, and retryableErrorFn