feat!: automatically detect contentType if not provided #1190

atn · 2020-05-12T20:06:12Z

Fixes #1184 🦕

In a rush, I didn't have time to edit tests.ts file. It would be appreciated if someone could!

googlebot · 2020-05-12T20:06:16Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

atn · 2020-05-12T20:08:23Z

@googlebot I signed it!

googlebot · 2020-05-12T20:08:26Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

stephenplusplus · 2020-05-12T21:20:22Z

Thank you! I will take it over :)

googlebot · 2020-05-12T23:48:48Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

stephenplusplus · 2020-05-12T23:49:35Z

src/bucket.ts

@@ -3438,12 +3438,6 @@ class Bucket extends ServiceObject {
      });
    }

-    const contentType = mime.contentType(path.basename(pathString));


Removed as this is identically covered inside of createWriteStream() when this code makes its way there.

atn · 2020-05-13T00:39:26Z

@googlebot I consent.

codecov · 2020-05-13T00:56:18Z

Codecov Report

Merging #1190 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
+ Coverage   99.17%   99.29%   +0.11%     
==========================================
  Files          12       12              
  Lines       11454    11474      +20     
  Branches      594      805     +211     
==========================================
+ Hits        11360    11393      +33     
+ Misses         94       81      -13

Impacted Files	Coverage Δ
src/bucket.ts	`99.83% <ø> (+0.30%)`	⬆️
src/file.ts	`100.00% <100.00%> (+0.05%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a4044a...4e119d7. Read the comment docs.

googlebot · 2020-05-13T20:29:12Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

This is to upgrade the vulnerable `date-and-time` dependency. The latest version has the following breaking changes which are all okay: - automatically detect contentType if not provided (googleapis/nodejs-storage#1190) - drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166) - drop support for node.js 8.x - allow leading slashes in file name (googleapis/nodejs-storage#820) - upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)

This is to upgrade the vulnerable `axios` dependency. The latest version has the following breaking changes which are all okay: - automatically detect contentType if not provided (googleapis/nodejs-storage#1190) - drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166) - drop support for node.js 8.x - allow leading slashes in file name (googleapis/nodejs-storage#820) - upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)

This is to upgrade the vulnerable `date-and-time` dependency. The latest version has the following breaking changes which are all okay: - automatically detect contentType if not provided (googleapis/nodejs-storage#1190) - drop keepAcl parameter in file copy (googleapis/nodejs-storage#1166) - drop support for node.js 8.x - allow leading slashes in file name (googleapis/nodejs-storage#820) - upgrade engines field to >=8.10.0 (googleapis/nodejs-storage#688)

Automatically change contentType to auto if none provided.

c61fa48

atn requested a review from a team as a code owner May 12, 2020 20:06

Merge c61fa48 into 0bb1909

7fa18d3

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 12, 2020

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 12, 2020

stephenplusplus self-assigned this May 12, 2020

add tests

3c0a9a7

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels May 12, 2020

stephenplusplus reviewed May 12, 2020

View reviewed changes

stephenplusplus changed the title ~~Automatically change contentType to auto if none provided.~~ feat: automatically detect contentType if not provided May 13, 2020

stephenplusplus changed the title ~~feat: automatically detect contentType if not provided~~ feat!: automatically detect contentType if not provided May 13, 2020

stephenplusplus mentioned this pull request May 13, 2020

chore: release 5.0.0 #1157

Merged

stephenplusplus requested a review from AVaksman May 13, 2020 14:31

stephenplusplus and others added 2 commits May 13, 2020 10:32

Merge branch 'master' into master

7dd866d

Merge branch 'master' into master

4e119d7

jkwlui added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 13, 2020

jkwlui added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2020

stephenplusplus requested a review from jkwlui May 13, 2020 20:39

stephenplusplus removed the request for review from AVaksman May 13, 2020 20:39

jkwlui approved these changes May 13, 2020

View reviewed changes

jkwlui merged commit b31ba4a into googleapis:master May 13, 2020

dmitry-fa mentioned this pull request May 20, 2020

Feature suggestion: auto content-type on blob creation googleapis/java-storage#47

Closed

dmitry-fa mentioned this pull request Jun 1, 2020

feat: auto content-type on blob creation googleapis/java-storage#338

Merged

BYK mentioned this pull request Jan 4, 2021

upgrade(@google-cloud/storage): ^5.7.0 getsentry/sentry-javascript#3146

Merged

BYK mentioned this pull request Jan 5, 2021

upgrade(@google-cloud/storage): ^5.7.0 getsentry/craft#157

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: automatically detect contentType if not provided #1190

feat!: automatically detect contentType if not provided #1190

atn commented May 12, 2020

googlebot commented May 12, 2020

atn commented May 12, 2020

googlebot commented May 12, 2020

stephenplusplus commented May 12, 2020

googlebot commented May 12, 2020

stephenplusplus May 12, 2020

atn commented May 13, 2020

codecov bot commented May 13, 2020 •

edited

Loading

googlebot commented May 13, 2020

feat!: automatically detect contentType if not provided #1190

feat!: automatically detect contentType if not provided #1190

Conversation

atn commented May 12, 2020

googlebot commented May 12, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

atn commented May 12, 2020

googlebot commented May 12, 2020

stephenplusplus commented May 12, 2020

googlebot commented May 12, 2020

stephenplusplus May 12, 2020

Choose a reason for hiding this comment

atn commented May 13, 2020

codecov bot commented May 13, 2020 • edited Loading

Codecov Report

googlebot commented May 13, 2020

codecov bot commented May 13, 2020 •

edited

Loading