Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): wrap GetSignedUrlResponse #1119

Merged
merged 1 commit into from
Mar 20, 2020
Merged

fix(types): wrap GetSignedUrlResponse #1119

merged 1 commit into from
Mar 20, 2020

Conversation

stephenplusplus
Copy link
Contributor

Fixes #1114

File#getSignedUrl() returns what URLSigner#getSignedUrl() returns. But, the File method is promisified, which means we actually send back [resp], and not just resp. Does this solution make sense?

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2020
@stephenplusplus stephenplusplus merged commit 0c7ac16 into googleapis:master Mar 20, 2020
@stephenplusplus stephenplusplus deleted the spp--1114 branch March 20, 2020 20:44
@jkwlui jkwlui mentioned this pull request Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwlui jkwlui jkwlui approved these changes

@bcoe bcoe Awaiting requested review from bcoe

@JustinBeckwith JustinBeckwith Awaiting requested review from JustinBeckwith

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getSignedUrl has wrong return type, should be an array of string
3 participants
@stephenplusplus @jkwlui @googlebot