Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add remove conditional binding #1107

Merged
merged 2 commits into from
Mar 17, 2020
Merged

feat: add remove conditional binding #1107

merged 2 commits into from
Mar 17, 2020

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Mar 17, 2020

Add remove conditional binding

@frankyn frankyn requested a review from jkwlui March 17, 2020 01:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2020
@codecov
Copy link

codecov bot commented Mar 17, 2020 •
edited
Loading

Codecov Report

Merging #1107 into master will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1107      +/-   ##
==========================================
- Coverage   99.21%   99.08%   -0.13%     
==========================================
  Files          12       12              
  Lines       11057    11057              
  Branches      571      564       -7     
==========================================
- Hits        10970    10956      -14     
- Misses         87      101      +14
Impacted Files Coverage Δ
bin/benchwrapper.js 0.00% <0.00%> (ø)
src/signer.ts 99.27% <0.00%> (-0.49%) ⬇️
src/bucket.ts 99.38% <0.00%> (-0.20%) ⬇️
src/file.ts 99.78% <0.00%> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da560d3...fe0b08a. Read the comment docs.

@frankyn frankyn marked this pull request as ready for review March 17, 2020 01:15
@bcoe bcoe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 17, 2020
@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Mar 17, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 2143705 into master Mar 17, 2020
@frankyn frankyn deleted the add-remove-iam-sample branch March 17, 2020 23:17
@frankyn frankyn mentioned this pull request Mar 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwlui jkwlui jkwlui approved these changes

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frankyn @bcoe @jkwlui @googlebot @yoshi-kokoro