-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): Add versioning as optional metadata param for createBucket #1090
feat(storage): Add versioning as optional metadata param for createBucket #1090
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
2c53997
to
b89f57f
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
system-test/storage.ts
Outdated
const bucket = storage.bucket(generateName()); | ||
await storage.createBucket(bucket.name); | ||
await bucket.getMetadata(); | ||
assert.strictEqual(bucket.metadata.versioning.enabled, null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert.strictEqual(bucket.metadata.versioning.enabled, null); | |
assert.strictEqual(bucket.metadata.versioning, undefined); |
I believe in the default case metadata
won't have the versioning
property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, fixed this and repushed
274ba7c
to
eecffda
Compare
eecffda
to
0b52890
Compare
Thank you for the contribution! @akabraham |
Fixes #1089 🦕