feat(v4): support v4 signed URL for GA #1072

jkwlui · 2020-02-12T01:00:54Z

Closes #1043
Closes #1044
Closes #1045
Closes #1046

* refactor signed url logic into its own class * fix the test * refactor tests to test/signer.ts * npm run fix * chore: generate synth.metadata * allow bucket-operation signed url * remove unused types * support bucket operations * refactor signer to not use promisify * fix node-8 test * add test for generation parameter * test: add list bucket signed url system-test * npm run fix * fix bucket getSignedUrl docs * chore(deps): update dependency @types/mocha to v7 * fix: unhandled promise rejection warning in samples (#1056) * fix: unhandledPromiseRejectionWarning in samples * fix: lint issue * fix: lint issue Co-authored-by: Benjamin E. Coe <[email protected]> * docs(readme): log errors in sample * chore: skip img.shields.io in docs test Co-authored-by: Yoshi Automation Bot <[email protected]> Co-authored-by: WhiteSource Renovate <[email protected]> Co-authored-by: Lalji Kanjareeya <[email protected]> Co-authored-by: Benjamin E. Coe <[email protected]> Co-authored-by: Justin Beckwith <[email protected]>

…134282 (#1066) * update conformance test json to conformance-test@9f134282 * parse updated conformance-test format * npm run fix * pass queryParameters to conformance test * conformance tests ignore query parameter ordering in URL * npm run fix * parse sha256 option * revert debug

* update conformance test json to conformance-test@9f134282 * parse updated conformance-test format * npm run fix * fix(signed-url): trailing `/` after path before query params

googlebot · 2020-02-12T01:00:58Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-02-12T01:01:36Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2020-02-12T01:01:49Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

* update conformance test json to conformance-test@9f134282 * parse updated conformance-test format * npm run fix * pass queryParameters to conformance test * conformance tests ignore query parameter ordering in URL * npm run fix * parse sha256 option * revert debug * fix(signed-url): include custom query parameters in signature calculation * query param wip * fix queryParam sorting * test: query params are sorted * remove unused imports * npm run fix * refactor * rename QueryParams to just Query

codecov · 2020-02-12T19:57:50Z

Codecov Report

❗ No coverage uploaded for pull request base (master@6720d53). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1072   +/-   ##
=========================================
  Coverage          ?   98.97%           
=========================================
  Files             ?       12           
  Lines             ?    10991           
  Branches          ?      496           
=========================================
  Hits              ?    10878           
  Misses            ?      111           
  Partials          ?        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6720d53...d7bd23e. Read the comment docs.

* update conformance test json to conformance-test@9f134282 * parse updated conformance-test format * npm run fix * vhost * unit tests * npm run fix * docs: document urlStyle option for Bucket * test: add system-test to exercise virtual-hosted url * pass queryParameters to conformance test * conformance tests ignore query parameter ordering in URL * npm run fix * parse sha256 option * revert debug * restyle option as virtualHostedStyle as a boolean * npm run fix * docs: virtualHostedStyle option defaults to false * docs: fix path style example

* feat(signed-url): support SHA256 for signed payloads * add unit test * remove junk import * newline * document contentMd5 option * do not provide contentSha256 option, instead, detect user provided header

googlebot · 2020-02-14T23:38:31Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

googlebot · 2020-02-15T00:09:43Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-03-02T21:19:44Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-03-02T21:32:11Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

jkwlui · 2020-03-03T23:31:08Z

@stephenplusplus Thank you for your review!

I addressed your feedback, please take a look when you have a moment.

googlebot · 2020-03-03T23:31:24Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to determine that you authored the commits in this PR. Maybe you used a different email address in the git commits than was used to sign the CLA? If someone else authored these commits, then please add them to this pull request and have them confirm that they're okay with them being contributed to Google. If there are co-authors, make sure they're formatted properly.

In order to pass this check, please resolve this problem and then comment@googlebot I fixed it... If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-03-04T21:26:45Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

stephenplusplus · 2020-03-05T15:29:21Z

Thank you very much, looks great to me!

jkwlui and others added 3 commits February 10, 2020 14:07

fix(signed-url): trailing / after path before query params (#1068)

574b364

* update conformance test json to conformance-test@9f134282 * parse updated conformance-test format * npm run fix * fix(signed-url): trailing `/` after path before query params

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 12, 2020

jkwlui changed the title ~~feat(v4): GA master branch~~ feat(v4): support v4 signed URL for GA Feb 12, 2020

jkwlui added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 12, 2020

Merge branch 'master' into v4-ga

e874fa8

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Feb 12, 2020

jkwlui added do not merge Indicates a pull request not ready for merge, due to either quality or timing. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 12, 2020

jkwlui self-assigned this Feb 12, 2020

jkwlui added 5 commits February 12, 2020 16:00

fix: resource path beginning with /

c050bce

feat(signed-url): support SHA256 for signed payloads (#1070)

ddeeafe

* feat(signed-url): support SHA256 for signed payloads * add unit test * remove junk import * newline * document contentMd5 option * do not provide contentSha256 option, instead, detect user provided header

npm run fix

10a09d8

Merge branch 'master' into v4-ga

332dd79

jkwlui added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 14, 2020

jkwlui mentioned this pull request Feb 14, 2020

V4 responseDisposition breaks signature validation #1073

Closed

jkwlui added 2 commits February 14, 2020 15:52

fix system-test

f68df70

Merge branch 'v4-ga' of github.com:googleapis/nodejs-storage into v4-ga

efe7602

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 2, 2020

jkwlui added 2 commits March 2, 2020 13:02

Merge branch 'master' into v4-ga

aef6118

Merge branch 'master' into v4-ga

999040c

jkwlui added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 2, 2020

Merge branch 'master' into v4-ga

5574619

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 2, 2020

jkwlui added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 2, 2020

googleapis deleted a comment from googlebot Mar 3, 2020

Merge branch 'master' into v4-ga

6720d53

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 3, 2020

Merge branch 'master' into v4-ga

d7bd23e

jkwlui added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 4, 2020

stephenplusplus approved these changes Mar 5, 2020

View reviewed changes

jkwlui merged commit 79d7b8f into master Mar 5, 2020

jkwlui deleted the v4-ga branch March 5, 2020 23:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(v4): support v4 signed URL for GA #1072

feat(v4): support v4 signed URL for GA #1072

jkwlui commented Feb 12, 2020 •

edited

Loading

googlebot commented Feb 12, 2020

googlebot commented Feb 12, 2020

googlebot commented Feb 12, 2020

codecov bot commented Feb 12, 2020 •

edited

Loading

googlebot commented Feb 14, 2020

googlebot commented Feb 15, 2020

googlebot commented Mar 2, 2020

googlebot commented Mar 2, 2020

jkwlui commented Mar 3, 2020

googlebot commented Mar 3, 2020

googlebot commented Mar 4, 2020

stephenplusplus commented Mar 5, 2020

feat(v4): support v4 signed URL for GA #1072

feat(v4): support v4 signed URL for GA #1072

Conversation

jkwlui commented Feb 12, 2020 • edited Loading

googlebot commented Feb 12, 2020

googlebot commented Feb 12, 2020

googlebot commented Feb 12, 2020

codecov bot commented Feb 12, 2020 • edited Loading

Codecov Report

googlebot commented Feb 14, 2020

googlebot commented Feb 15, 2020

googlebot commented Mar 2, 2020

googlebot commented Mar 2, 2020

jkwlui commented Mar 3, 2020

googlebot commented Mar 3, 2020

googlebot commented Mar 4, 2020

stephenplusplus commented Mar 5, 2020

jkwlui commented Feb 12, 2020 •

edited

Loading

codecov bot commented Feb 12, 2020 •

edited

Loading