Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor getMetadata sample into its own file #1008

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Conversation

sofisl
Copy link
Contributor

@sofisl sofisl commented Jan 8, 2020

No description provided.

@sofisl sofisl requested a review from fhinkel January 8, 2020 22:12
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 8, 2020
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #1008 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
+ Coverage      99%   99.01%   +<.01%     
==========================================
  Files          11       11              
  Lines       10659    10708      +49     
  Branches      473      473              
==========================================
+ Hits        10553    10602      +49     
  Misses        106      106
Impacted Files Coverage Δ
src/file.ts 99.65% <ø> (-0.01%) ⬇️
src/storage.ts 100% <100%> (ø) ⬆️
src/bucket.ts 99.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 517218d...b68d0c9. Read the comment docs.

@jkwlui jkwlui merged commit 6ed1af8 into master Jan 16, 2020
@jkwlui jkwlui deleted the getMetadata branch January 16, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants