fix: validate action of getSignedUrl() function (#684)

* validate action of getSignedUrl() function * use existing enum for validation
googleapis · May 1, 2019 · 1b09d24 · 1b09d24
1 parent 8b40e6a
commit 1b09d24
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/src/file.ts b/src/file.ts
@@ -2334,6 +2334,10 @@ class File extends ServiceObject<File> {
 
     const method = ActionToHTTPMethod[cfg.action];
 
+    if (!method) {
+      throw new Error('The action is not provided or invalid.');
+    }
+
     const name = encodeURIComponent(this.name);
     const resource = `/${this.bucket.name}/${name}`;
 

diff --git a/test/file.ts b/test/file.ts
@@ -2556,6 +2556,28 @@ describe('File', () => {
       }, /Invalid signed URL version: v42\. Supported versions are 'v2' and 'v4'\./);
     });
 
+    it('should error if action is null', () => {
+      const config = Object.assign({}, CONFIG, {action: null});
+      assert.throws(() => {
+        file.getSignedUrl(config, () => {});
+      }, /The action is not provided or invalid./);
+    });
+
+    it('should error if action is undefined', () => {
+      const config = Object.assign({}, CONFIG);
+      delete config.action;
+      assert.throws(() => {
+        file.getSignedUrl(config, () => {});
+      }, /The action is not provided or invalid./);
+    });
+
+    it('should error for an invalid action', () => {
+      const config = Object.assign({}, CONFIG, {action: 'watch'});
+      assert.throws(() => {
+        file.getSignedUrl(config, () => {});
+      }, /The action is not provided or invalid./);
+    });
+
     describe('v4 signed URL', () => {
       beforeEach(() => {
         CONFIG.version = 'v4';