Page MenuHomePhabricator

1.44.0-wmf.5 deployment blockers
Closed, ResolvedPublic5 Estimated Story PointsRelease

Details

Backup Train Conductor
Aklapper
Release Version
1.44.0-wmf.5
Release Date
Mon, Nov 25, 12:00 AM

2024 week 48 1.44-wmf.5 Changes wmf/1.44.0-wmf.5

This MediaWiki Train Deployment is scheduled for the week of Monday, November 25th:

Monday November 25thTuesday, November 26thWednesday, November 27thThursday, November 28thFriday
Backports only.Branch wmf.5 and deploy to Group 0 Wikis.Deploy wmf.5 to Group 1 Wikis.Deploy wmf.5 to all Wikis.No deployments on fridays

How this works

  • Any serious bugs affecting wmf.5 should be added as subtasks beneath this one.
  • Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
  • If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
  • If you have a risky change in this week's train add a comment to this task using the Risky patch template
  • For more info about deployment blockers, see Holding the train.

Related Links

Other Deployments

Previous: 1.44.0-wmf.4
Next: 1.44.0-wmf.6

Event Timeline

thcipriani renamed this task from 1.43.0-wmf.33 deployment blockers to 1.44.0-wmf.5 deployment blockers.Sep 26 2024, 1:03 AM
thcipriani changed Release Version from 1.43.0-wmf.33 to 1.44.0-wmf.5.
thcipriani triaged this task as Medium priority.
thcipriani updated Other Assignee, added: Aklapper.
thcipriani set the point value for this task to 5.

Noting that this week's train is happening over US Thanksgiving. Due to the holiday, if we run into a blocker we need the US cabal to resolve, then we may need to abandon this week's train and pick it up with 1.44.0-wmf.6 next week.

I hope this will be unlikely, we're run the train over the week of Thanksgiving for the past two years and all went well.

Change #1097581 had a related patch set uploaded (by TrainBranchBot; author: trainbranchbot):

[mediawiki/core@wmf/1.44.0-wmf.5] Branch commit for wmf/1.44.0-wmf.5

https://gerrit.wikimedia.org/r/1097581

Change #1097581 merged by jenkins-bot:

[mediawiki/core@wmf/1.44.0-wmf.5] Branch commit for wmf/1.44.0-wmf.5

https://gerrit.wikimedia.org/r/1097581

I was looking at the roadmap linked above

image.png (1×2 px, 276 KB)

which seem to suggest that wmf.5 will not be deployed. While the comment above

Noting that this week's train is happening over US Thanksgiving. Due to the holiday, if we run into a blocker we need the US cabal to resolve, then we may need to abandon this week's train and pick it up with 1.44.0-wmf.6 next week.

is more optimistic that there will be wmf.5.

Unfortunately, the extension Math has 5 commits (T380184#10355795) that should be included in wmf.5. I tried to cherry pick the first commit, but it failed, and I don't know how to create patches for the other 4 nor I'm available in todays backport window. I would greatly appreciate if someone can merge the fixes into wmf.5.

!log Fast forwarded mediawiki/extensions/Math wmf/1.44.0-wmf.5 branch from 0458ea16 to d5076423. That is to apply hotfixes that merged after the branch has been cut # T375664 | T380184

We have an ongoing issue with toolforge T380844 which breaks the MediaWiki train, notably our automatic jobs that processes the branch.

On IRC @jnuche wrote:

I checked the error from the nightly patches check job, it seems to be failing due to the same failure that made the presync fail. We are > getting sporadic failures from the train-blockers app:

$ while :; do curl -s https://train-blockers.toolforge.org/api.php | jq -r '.current.version'; sleep 1; done
1.44.0-wmf.5
parse error: Invalid numeric literal at line 1, column 4
parse error: Invalid numeric literal at line 1, column 4
1.44.0-wmf.5

Change #1097980 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] testwikis to 1.44.0-wmf.5

https://gerrit.wikimedia.org/r/1097980

Change #1097980 merged by jenkins-bot:

[operations/mediawiki-config@master] testwikis to 1.44.0-wmf.5

https://gerrit.wikimedia.org/r/1097980

Mentioned in SAL (#wikimedia-operations) [2024-11-26T10:47:37Z] <hashar@deploy2002> Started scap sync-world: testwikis to 1.44.0-wmf.5 refs T375664

Mentioned in SAL (#wikimedia-operations) [2024-11-26T11:25:08Z] <hashar@deploy2002> Started scap sync-world: testwikis to 1.44.0-wmf.5 refs T375664

Mentioned in SAL (#wikimedia-operations) [2024-11-26T11:28:52Z] <hashar@deploy2002> Started scap sync-world: testwikis to 1.44.0-wmf.5 refs T375664

Mentioned in SAL (#wikimedia-operations) [2024-11-26T11:54:44Z] <hashar@deploy2002> Finished scap sync-world: testwikis to 1.44.0-wmf.5 refs T375664 (duration: 25m 52s)

Change #1098011 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group0 to 1.44.0-wmf.5

https://gerrit.wikimedia.org/r/1098011

Change #1098011 merged by jenkins-bot:

[operations/mediawiki-config@master] group0 to 1.44.0-wmf.5

https://gerrit.wikimedia.org/r/1098011

Mentioned in SAL (#wikimedia-operations) [2024-11-26T12:26:12Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group0 to 1.44.0-wmf.5 refs T375664

Summary

I have confirmed yesterday scap clean --delete-gerrit-branch properly delete old wmf branches (solving T303828). I have adjusted the timer that runs it automatically on Tuesday ( 7d301cb368631b2d22451b22c6e21658a35243cf ), and thanks to Reuven that got deployed before it starts. I have confirmed this morning it ran properly.

Ahead of running the train, I went to start tackling a similar task for release branches (T380841). The dry run scripts looked fine but upon running targetting REL1_19 that ended up deleting the branch and tagging the HEAD of the repo instead of the old commit. I thus went to restore those branch which delayed my attention.

Jaime Nuche mentioned the nightly patches check job failed (release Jenkins: Branch cut test patches job), investigated and found out it was due to https://train-blockers.toolforge.org/ not being available.

The overnight presync failed as well:

requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: https://train-blockers.toolforge.org/api.php

The root cause was T380844.

syncing

The manual sync took a while since the presync step did not run. The images had to be build, all the data transferred and it is rather lengthy. Eventually a canary check failed and I had it immediately aborted cause I previously pressed in the terminal, that got read by scap and validated the default to abort the deployment. I gotta complete https://gitlab.wikimedia.org/repos/releng/scap/-/merge_requests/468 to fix that. That first run took ~ 38 minutes.

I started a second run at 11:25 and immediately aborted it because a mediawiki-config change got merged during the window (Gerrit 1062430 - config: remove eventbus instrumentation setting for T363587). I have thus aborted the train, reverted the patch (Gerrit 1097995).

I then did a third run to promote testwikis and it logged a 25 minutes duration.

Amir had a backport pending which automatically triggered, that took 15 minutes more. After that I have promoted the wikis to group 0 which took ~ 12 minutes.

Change #1098471 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group1 to 1.44.0-wmf.5

https://gerrit.wikimedia.org/r/1098471

Change #1098471 merged by jenkins-bot:

[operations/mediawiki-config@master] group1 to 1.44.0-wmf.5

https://gerrit.wikimedia.org/r/1098471

Mentioned in SAL (#wikimedia-operations) [2024-11-27T09:44:59Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group1 to 1.44.0-wmf.5 refs T375664

Change #1098887 had a related patch set uploaded (by TrainBranchBot; author: Hashar):

[operations/mediawiki-config@master] group2 to 1.44.0-wmf.5

https://gerrit.wikimedia.org/r/1098887

Change #1098887 merged by jenkins-bot:

[operations/mediawiki-config@master] group2 to 1.44.0-wmf.5

https://gerrit.wikimedia.org/r/1098887

Mentioned in SAL (#wikimedia-operations) [2024-11-28T09:22:19Z] <hashar@deploy2002> rebuilt and synchronized wikiversions files: group2 to 1.44.0-wmf.5 refs T375664

I am claiming the train to have successfully completed!