After the creation of a port for CTM (misc/ctm) it can be removed from -CURRENT.
No MFC is planned at this time, although the port has been made available as a package for all supported versions of FreeBSD.
Details
- Reviewers
imp rgrimes bcr - Group Reviewers
manpages - Commits
- rS342126: Remove CTM from 13-CURRENT after the release of FreeBSD-12.0.
Remove source files, Makefile entry and WITHOUT_CTM option.
Build and install world without CTM.
Remove obsolete CTM files from base with "make delete-old".
Verify that the world has been successfully built and installed and that all files that used to depend on MK_CTM in OptionalObsoleteFiles.inc are gone.
The misc/ctm port has already been verified to build and run identical to the version to be removed from base.
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
There should be an UPDATING entry to tell people to go get the port.. This has a 0 length deprecation notice if we just go rip it out now. I would support first adding a gonein(13) and merging that to release 12 or 12.1. That should be done first, before this. Have the ports builders made a pkg avaliable for ^/head yet, I see that you can build it, but can pkg get one yet? I would not want to remove it until a binary can be fetched via pkg.
Looks good to me. I'd do a separate commit that just says 'CTM will move to ports in FreeBSD 13' in the ctm man page and get that merged before 12.0R (so ASAP).
I agree with Rob we should have an updating entry, and a line in the release notes (relnotes: yes should do that).
I don't think we need to do anything more other than commit this review after a few month (there's no rush, and safely after the turbulence 12.0R is mildly better), but I'll give that feedback and leave the timing to your discretion.
Please do both the man page, and actually more importantly make the binary spit out a warning that it is going away in 13, this to be merged to stable/12 asap. Man pages simply do not get peoples attention. Also make sure to mark this commits as relnotes: y.
Since I am involved now I can not approve it as re@, but it should see no resistance.
Am 12.11.18 um 19:29 schrieb rgrimes:
rgrimes added a comment.
In D17935#383667 <https://reviews.freebsd.org/D17935#383667>, @imp wrote: > I'd do a separate commit that just says 'CTM will move to ports in > FreeBSD 13' in the ctm man page and get that merged before 12.0R (so > ASAP). Please do both the man page, and actually more importantly make the binary spit out a warning that it is going away in 13, this to be merged to stable/12 asap. Man pages simply do not get peoples attention. Also make sure to mark this commits as relnotes: y. Since I am involved now I can not approve it as re@, but it should see no resistance.
Hi Warner and Rod,
thank you for the review and suggestions. I'll try to get
the requested changes worked out today or tomorrow and I'll
update the review item and send a request for approval of
the MFC to RE.
Regards, STefan