Page MenuHomePhabricator

VisualEditorUmbrella
ActivePublic

Details

Description

VisualEditor is a project to create a reliable, full-featured rich-text or "visual" HTML editor for the Web. Though VisualEditor itself is an HTML editor, it is integrated into platforms for use there, primary in MediaWiki-General with the VisualEditor-MediaWiki integration, used in conjunction with the Parsoid parsing service to provide the HTML+RDFa.

Our projects are arranged as follows:

  • VisualEditor – Anything related to VisualEditor, including related extensions.

Recent Activity

Yesterday

Bhsd added a comment to T357482: 2017 wikitext editor integration in CodeMirror 6.

The misalignment I reported earlier has been fixed.

Sat, Nov 9, 10:58 AM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Community-Tech, MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror
ppelberg merged task T350191: Analyze how people engage with page tools while editing into T378036: BASELINE: How do people use Tools and Appearance menus while editing?.
Sat, Nov 9, 12:58 AM · Editing-team (Tracking), Product-Analytics, EditCheck, VisualEditor
ppelberg merged T350191: Analyze how people engage with page tools while editing into T378036: BASELINE: How do people use Tools and Appearance menus while editing?.
Sat, Nov 9, 12:58 AM · Product-Analytics (Kanban), Editing-team (Tracking), VisualEditor, EditCheck
ppelberg added a comment to T379444: Web team to provide stable API for visual control of right rail.

@Jdlrobson please add/edit this task as you see fit. It very much is a rough first pass based on what we talked about briefly offline on 5 November.

Sat, Nov 9, 12:57 AM · Editing-team (Tracking), VisualEditor, Web-Team-Backlog, EditCheck
ppelberg updated the task description for T379443: Hide Tools and Appearance menus for junior contributors while editing.
Sat, Nov 9, 12:35 AM · VisualEditor, Web-Team-Backlog, Editing-team (Kanban Board), EditCheck
ppelberg created T379444: Web team to provide stable API for visual control of right rail.
Sat, Nov 9, 12:30 AM · Editing-team (Tracking), VisualEditor, Web-Team-Backlog, EditCheck
ppelberg added projects to T379443: Hide Tools and Appearance menus for junior contributors while editing: Web-Team-Backlog, VisualEditor.
Sat, Nov 9, 12:22 AM · VisualEditor, Web-Team-Backlog, Editing-team (Kanban Board), EditCheck

Fri, Nov 8

ppelberg added a project to T379341: Create a way to persist annotations to the VE document across edit sessions: VisualEditor.
Fri, Nov 8, 11:55 PM · VisualEditor, EditCheck
ppelberg updated the task description for T378036: BASELINE: How do people use Tools and Appearance menus while editing?.
Fri, Nov 8, 11:54 PM · Product-Analytics (Kanban), Editing-team (Tracking), VisualEditor, EditCheck
ppelberg added a comment to T378036: BASELINE: How do people use Tools and Appearance menus while editing?.

I've confirmed instrumentation is available in event.mediawiki_web_ui_actions to calculate the metrics identified for this task. This includes ability to track click to the "hide" button and clicks to the menu options for both the appearance and tools menu.

Great news; thank you for looking into this @MNeisler.

Note: I will be attending an offsite next week (away Nov 11-19) but will plan to work on this analysis when when I return.

Sounds great!

Fri, Nov 8, 11:51 PM · Product-Analytics (Kanban), Editing-team (Tracking), VisualEditor, EditCheck
Jdlrobson added a project to T379428: [regression] VE mobile menu items unexpectedly bold: Web-Team-Backlog (FY2024-25 Q2 Sprint 4).
Fri, Nov 8, 10:01 PM · Web-Team-Backlog (FY2024-25 Q2 Sprint 4), Patch-For-Review, Regression, MinervaNeue, VisualEditor
Esanders updated subscribers of T344370: VE fake toolbar button close button doesn't line up with real toolbar.

As @matmarex pointed out in the patch, the fixed with [x] button (as opposed to 1/7th width) is also used in the wikitext editor, so we should fix that as well.

Fri, Nov 8, 9:35 PM · Patch-For-Review, Regression, VisualEditor, MobileFrontend
Esanders triaged T379428: [regression] VE mobile menu items unexpectedly bold as Medium priority.
Fri, Nov 8, 9:29 PM · Web-Team-Backlog (FY2024-25 Q2 Sprint 4), Patch-For-Review, Regression, MinervaNeue, VisualEditor
Maintenance_bot added a project to T379427: Use the JSDoc WMF theme for the TemplateData JS docs site: VisualEditor.
Fri, Nov 8, 9:29 PM · VisualEditor, TemplateData
gerritbot added a project to T379428: [regression] VE mobile menu items unexpectedly bold: Patch-For-Review.
Fri, Nov 8, 9:29 PM · Web-Team-Backlog (FY2024-25 Q2 Sprint 4), Patch-For-Review, Regression, MinervaNeue, VisualEditor
gerritbot added a comment to T379428: [regression] VE mobile menu items unexpectedly bold.

Change #1088643 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/skins/MinervaNeue@master] Follow-up Iefa1fee9c: Remove bold styling from all non-href links

https://gerrit.wikimedia.org/r/1088643

Fri, Nov 8, 9:28 PM · Web-Team-Backlog (FY2024-25 Q2 Sprint 4), Patch-For-Review, Regression, MinervaNeue, VisualEditor
Esanders created T379428: [regression] VE mobile menu items unexpectedly bold.
Fri, Nov 8, 9:25 PM · Web-Team-Backlog (FY2024-25 Q2 Sprint 4), Patch-For-Review, Regression, MinervaNeue, VisualEditor
GMikesell-WMF updated the task description for T373649: Copying and pasting large pages causes misalignment between CodeMirror and VE surfaces.
Fri, Nov 8, 6:26 PM · Community-Tech (Jackal (not a fox) Fox), MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
MusikAnimal closed T373649: Copying and pasting large pages causes misalignment between CodeMirror and VE surfaces, a subtask of T357482: 2017 wikitext editor integration in CodeMirror 6, as Resolved.
Fri, Nov 8, 6:26 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Community-Tech, MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror
MusikAnimal closed T373649: Copying and pasting large pages causes misalignment between CodeMirror and VE surfaces as Resolved.
Fri, Nov 8, 6:26 PM · Community-Tech (Jackal (not a fox) Fox), MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
GMikesell-WMF added a comment to T373649: Copying and pasting large pages causes misalignment between CodeMirror and VE surfaces.

@MusikAnimal On my laptop it's still overlapping on the load but not as bad as the previous one and actually cleaned it up more after the paste, as seen in the webm. On Browserstack, I did not come across that issue at all with the same OS and Browser version. Regardless like you said there were no issues with copying and pasting so I will move this to Done. Thanks for all your work!

Fri, Nov 8, 6:25 PM · Community-Tech (Jackal (not a fox) Fox), MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
GMikesell-WMF moved T373649: Copying and pasting large pages causes misalignment between CodeMirror and VE surfaces from QA to Done on the Community-Tech (Jackal (not a fox) Fox) board.
Fri, Nov 8, 6:21 PM · Community-Tech (Jackal (not a fox) Fox), MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror
ppelberg moved T379397: Use BERT model to identify when Peacock words are present from Untriaged to This Fiscal Year on the Editing-team board.
Fri, Nov 8, 6:07 PM · EditCheck, Editing-team, VisualEditor
ppelberg created T379397: Use BERT model to identify when Peacock words are present.
Fri, Nov 8, 6:07 PM · EditCheck, Editing-team, VisualEditor
Maintenance_bot removed a project from T379367: VE doesn't ask you to discard your edits if loaded via action=edit: Patch-For-Review.
Fri, Nov 8, 4:30 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
ReleaseTaggerBot added a project to T379367: VE doesn't ask you to discard your edits if loaded via action=edit: MW-1.44-notes (1.44.0-wmf.3; 2024-11-12).
Fri, Nov 8, 4:00 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
MNeisler added a comment to T378036: BASELINE: How do people use Tools and Appearance menus while editing?.

I've confirmed instrumentation is available in event.mediawiki_web_ui_actions to calculate the metrics identified for this task. This includes ability to track click to the "hide" button and clicks to the menu options for both the appearance and tools menu.

Fri, Nov 8, 3:40 PM · Product-Analytics (Kanban), Editing-team (Tracking), VisualEditor, EditCheck
MNeisler triaged T378036: BASELINE: How do people use Tools and Appearance menus while editing? as Medium priority.
Fri, Nov 8, 3:33 PM · Product-Analytics (Kanban), Editing-team (Tracking), VisualEditor, EditCheck
gerritbot added a comment to T379367: VE doesn't ask you to discard your edits if loaded via action=edit.

Change #1088567 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Handle view tab clicks even on edit pages

https://gerrit.wikimedia.org/r/1088567

Fri, Nov 8, 3:31 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
DLynch assigned T379367: VE doesn't ask you to discard your edits if loaded via action=edit to Esanders.
Fri, Nov 8, 3:16 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
Esanders added a comment to T130142: newFromDocumentInsertion transactions always replace the entire internal list.

The above patch will simplify transactions when the incoming document has no references (most image inerstions, most wikitext pastes). Simplifying transctions which involve references will be more complicated.

Fri, Nov 8, 2:58 PM · Patch-For-Review, Performance Issue, Technical-Debt, VisualEditor-DataModel, VisualEditor
gerritbot added a project to T130142: newFromDocumentInsertion transactions always replace the entire internal list: Patch-For-Review.
Fri, Nov 8, 2:58 PM · Patch-For-Review, Performance Issue, Technical-Debt, VisualEditor-DataModel, VisualEditor
gerritbot added a comment to T130142: newFromDocumentInsertion transactions always replace the entire internal list.

Change #1088581 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] newFromDocumentInsertion: Skip list replacement when new list is empty

https://gerrit.wikimedia.org/r/1088581

Fri, Nov 8, 2:57 PM · Patch-For-Review, Performance Issue, Technical-Debt, VisualEditor-DataModel, VisualEditor
Esanders added a comment to T377484: Can't paste a reference after recovering from autosave.

the stored transaction will include a full copy of the internalList before and after the change

Fri, Nov 8, 2:34 PM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Patch-For-Review, Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-10-16, Cite, VisualEditor
Esanders added a project to T379367: VE doesn't ask you to discard your edits if loaded via action=edit: Editing-team (Kanban Board).
Fri, Nov 8, 2:08 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
gerritbot added a project to T379367: VE doesn't ask you to discard your edits if loaded via action=edit: Patch-For-Review.
Fri, Nov 8, 2:08 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
gerritbot added a comment to T379367: VE doesn't ask you to discard your edits if loaded via action=edit.

Change #1088567 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Handle view tab clicks even on edit pages

https://gerrit.wikimedia.org/r/1088567

Fri, Nov 8, 2:07 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
Esanders created T379367: VE doesn't ask you to discard your edits if loaded via action=edit.
Fri, Nov 8, 2:04 PM · MW-1.44-notes (1.44.0-wmf.3; 2024-11-12), Editing QA, Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
Esanders updated the task description for T379287: Paste Check: set default configuration values.
Fri, Nov 8, 1:28 PM · Editing-team (Kanban Board), VisualEditor, EditCheck
Driedmueller changed the status of T379260: VisualEditor: Underscores between words shifts cursor to left and makes chars look italic from Invalid to Declined.
Fri, Nov 8, 10:01 AM · VisualEditor
Driedmueller closed T379260: VisualEditor: Underscores between words shifts cursor to left and makes chars look italic as Invalid.
Fri, Nov 8, 10:01 AM · VisualEditor
Driedmueller added a comment to T379260: VisualEditor: Underscores between words shifts cursor to left and makes chars look italic.

Just found out its a bug in VisualEditorPlus. Sorry for the inconvenience. Ticket can be closed.

Fri, Nov 8, 10:01 AM · VisualEditor
awight added a comment to T377484: Can't paste a reference after recovering from autosave.

There are some surprising entries in the ve-changes session storage. After making a change that involves a ref, the stored transaction will include a full copy of the internalList before and after the change, despite the difference only affecting a single item in the list.

Fri, Nov 8, 9:26 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Patch-For-Review, Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-10-16, Cite, VisualEditor
awight added a comment to T279215: TypeError: content.parts is undefined.

I still see this, and perhaps the cause is different than in the above? My steps to reproduce are:

Fri, Nov 8, 8:08 AM · MW-1.40-notes (1.40.0-wmf.24; 2023-02-20), JavaScript, VisualEditor, Wikimedia-production-error
awight claimed T377484: Can't paste a reference after recovering from autosave.
Fri, Nov 8, 6:44 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Patch-For-Review, Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-10-16, Cite, VisualEditor
awight moved T377484: Can't paste a reference after recovering from autosave from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2024-10-16 board.
Fri, Nov 8, 6:44 AM · MW-1.44-notes (1.44.0-wmf.2; 2024-11-05), Patch-For-Review, Unplanned-Sprint-Work, WMDE-TechWish-Sprint-2024-10-16, Cite, VisualEditor
ppelberg closed T371996: Create way to store ephemeral/temporary annotations to the VE document , a subtask of T359107: Paste Check: Prompt people pasting text to consider risk of copyright violation, as Resolved.
Fri, Nov 8, 5:38 AM · Patch-For-Review, Editing-team (Kanban Board), VisualEditor, EditCheck
ppelberg closed T371996: Create way to store ephemeral/temporary annotations to the VE document , a subtask of T365301: Peacock Check: Prompt people to revise promotional language, as Resolved.
Fri, Nov 8, 5:37 AM · EditCheck, Editing-team, VisualEditor
ppelberg closed T371996: Create way to store ephemeral/temporary annotations to the VE document as Resolved.
Fri, Nov 8, 5:37 AM · Editing-team (Kanban Board), EditCheck, VisualEditor

Thu, Nov 7

ppelberg updated the task description for T54174: VisualEditor: Make the edit summary a mini-VE surface so users can put in links etc..
Thu, Nov 7, 11:48 PM · DiscussionTools, VisualEditor, VisualEditor-MediaWiki