Page MenuHomePhabricator

Wikistories should not unconditionally link to WMF wikis
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikistories/+/e83afc40f27daa820a9026af29f0a09340fb54a8/resources/ext.wikistories.builder/views/PublishForm.vue#158

			const html = this.$i18n(
				'wikistories-builder-licensing-with-terms',
				'https://foundation.wikimedia.org/wiki/Terms_of_Use',
				'https://en.wikipedia.org/wiki/Wikipedia:Text_of_Creative_Commons_Attribution-ShareAlike_3.0_Unported_License',
				'https://en.wikipedia.org/wiki/Wikipedia:Text_of_the_GNU_Free_Documentation_License'
			).parse();

These URLs should not be hardcoded to point to WMF projects, and should instead be configurable.

Event Timeline

Pppery renamed this task from WikiStories should not unconditionally link to WMF wiki to WikiStories should not unconditionally link to WMF wikis.Oct 5 2024, 12:46 AM
SBisson renamed this task from WikiStories should not unconditionally link to WMF wikis to Wikistories should not unconditionally link to WMF wikis.Tue, Oct 15, 4:00 PM
SBisson claimed this task.
SBisson triaged this task as Medium priority.

Change #1080317 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/Wikistories@master] Introduce config variables for ToU and licence URLs

https://gerrit.wikimedia.org/r/1080317

Change #1080317 merged by jenkins-bot:

[mediawiki/extensions/Wikistories@master] Introduce config variables for ToU and licence URLs

https://gerrit.wikimedia.org/r/1080317

SBisson removed a project: Patch-For-Review.

Should ride the train next week