Page MenuHomePhabricator

Active links on minerva should not be yellow
Closed, ResolvedPublic

Description

Resurfaced in T357381 that we are using a non-standard color for links when long pressed.

variablecolor = daycolor = night
color-progressive--active#94b8ff#AFB6E9

QA Results - Beta

ACStatusDetails
1T358516#9615927

QA Results - Prod

ACStatusDetails
1T358516#9615932

Event Timeline

JScherer-WMF renamed this task from Active links on minerva should be blue, not yellow to Active links on minerva should not be yellow.Feb 26 2024, 6:08 PM
JScherer-WMF updated the task description. (Show Details)
ovasileva triaged this task as Medium priority.Feb 29 2024, 2:01 PM

This looks to have been fixed by https://phabricator.wikimedia.org/T359229

Since this is a visual change do we want to put it in tech news?

This looks to have been fixed by https://phabricator.wikimedia.org/T359229

Since this is a visual change do we want to put it in tech news?

Yeah, I think that's a good idea. Proposed copy: "We have changed the active color in Minerva to provide more consistency with our other platforms and best practices"

This looks to have been fixed by https://phabricator.wikimedia.org/T359229

Since this is a visual change do we want to put it in tech news?

Is this fixed in production? I am still seeing the yellow color at the moment.

Edtadros added subscribers: ovasileva, Edtadros.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://it.m.wikipedia.org/wiki/Alighieri or https://en.m.wikipedia.beta.wmflabs.org/wiki/Hooded_skunk
Long press a link to see the color change.
✅ The color should not change to yellow

screenshot 323.mov.gif (932×426 px, 736 KB)

screenshot 324.mov.gif (932×426 px, 501 KB)

Test Result - Prod

Status: ✅ PASS
Environment: itwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit https://it.m.wikipedia.org/wiki/Alighieri or https://en.m.wikipedia.beta.wmflabs.org/wiki/Hooded_skunk
Long press a link to see the color change.
✅ The color should not change to yellow

screenshot 322.mov.gif (932×426 px, 717 KB)

screenshot 321.mov.gif (932×426 px, 1 MB)