CirrusSearch integration tests should have a suite testing some wikibase related queries
Closed, ResolvedPublic5 Estimated Story Points
Actions

Assigned To

Authored By

	dcausse
	Jun 20 2023, 3:35 PM

Description

Followup on https://wikitech.wikimedia.org/w/index.php?title=Incidents/2023-06-18_search_broken_on_wikidata_and_commons

AC:

integration tests are failing if the wikibase index mapping/settings are incorrect
integration tests are failing if the queries generated by WikibaseCirrusSearch are incorrect

Details

	Subject	Repo	Branch	Lines +/-
	Add very basic integration tests for wikibasecirrussearch	mediawiki/extensions/CirrusSearch	master	+140 -38

Customize query in gerrit

Related Objects

Mentioned In: T339938: CirrusSearch should make sure the new index is able to respond to couple representative queries

Event Timeline

dcausse created this task.Jun 20 2023, 3:35 PM

Restricted Application added a project: Discovery-Search. · View Herald TranscriptJun 20 2023, 3:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Mnalis subscribed.Jun 21 2023, 10:14 PM

bking subscribed.Jun 26 2023, 3:31 PM

Gehel moved this task from needs triage to Current work on the Discovery-Search board.Jun 26 2023, 3:34 PM

Gehel edited projects, added Discovery-Search (Current work); removed Discovery-Search.

Gehel mentioned this in T339938: CirrusSearch should make sure the new index is able to respond to couple representative queries.Jun 26 2023, 3:37 PM

bking set the point value for this task to 5.Jul 10 2023, 3:30 PM

bking moved this task from Incoming to Ready for Dev -- SWE on the Discovery-Search (Current work) board.

EBernhardson claimed this task.Jul 10 2023, 9:29 PM

EBernhardson moved this task from Ready for Dev -- SWE to In Progress on the Discovery-Search (Current work) board.

Change 937195 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/extensions/CirrusSearch@master] Add very basic integration tests for wikibasecirrussearch

https://gerrit.wikimedia.org/r/937195

gerritbot added a project: Patch-For-Review.Jul 11 2023, 11:31 PM

EBernhardson moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.Jul 12 2023, 2:46 PM

The integration testing now enables analysis chain deduplication and uses the EntityFullTextQueryBuilder along with the typical rescore configuration on wikidata.org. The test itself now issues both a regular entity search and a wbsearchentities (prefix) search. I have verified, by manually checking out an older version of WikibaseCirrusSearch, that this now fails as expected with the patch the caused the incident, and the latest version of WBCS passes.

Change 937195 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Add very basic integration tests for wikibasecirrussearch

https://gerrit.wikimedia.org/r/937195

EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Jul 13 2023, 2:56 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.18; 2023-07-18).Jul 13 2023, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 13 2023, 3:10 PM

Gehel closed this task as Resolved.Jul 21 2023, 9:37 AM