Page MenuHomePhabricator
Create Task
Maniphest T188247

CX2: Automatic Translation card to adjust MT options
Closed, ResolvedPublic
Actions

Description

The Automatic translation card supports Machine Translation service selection for both the current paragraph and the default selection for the document. This helps translators to understand where the initial translation proposed comes from and which options they have to adjust it.

The Automatic translation card shows a selector with the different approaches to adapt the initial content: MT services available, copying the source content, or starting from scratch (empty content):

  • If “No automatic translation” is selected, the paragraph is empty, and the user can type
  • If “Source text” is selected, the source text must be pre-filled with adaptation of links, references, templates, math, and other formatting elements, but the same text.
  • If an MT engine was selected, in addition to adaptation of formatting, the text will be translated, too.

Changing the adaptation strategy affects also the options exposed:

  • Changes affect the current paragraph by default. When selecting a different translation service or strategy only the current paragraph is affected. A "Keep as default" action is shown when a non-default option is applied to allow making this the default from the next paragraphs.
    • "Keep as default" should not be shown initially when the translation service used is actually the default. This option should appear only when the user selected a different translation service that the one set as the default.
  • User modifications are preserved unless the user explicitly discards them. If I get a translation from Apertium, and I modify the content. After switching to Matxin and back to Apertium, I should get the version of the content I modified. There will be an option to reset the translation but that is not the default behaviour.

This is illustrated in more detail below:

mt-cad-simplified.png (811×1 px, 131 KB)

Related tickets:

Details

SubjectRepoBranchLines +/-
CX2: Implement "Reset translation" in MT cardmediawiki/extensions/ContentTranslationmaster+64 -10
CX2: Implement "Set as default" for MT cardmediawiki/extensions/ContentTranslationmaster+58 -8
CX2: Update selected MT engine status on MT failuremediawiki/extensions/ContentTranslationmaster+2 -2
CX2: Fix multiple MT related issuesmediawiki/extensions/ContentTranslationmaster+176 -86
Machine translation toolbarmediawiki/extensions/ContentTranslationmaster+337 -51
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF created this task.Feb 26 2018, 12:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2018, 12:44 PM
Pginer-WMF renamed this task from CX2: Card to adjust MT options to CX2: Automatic Translation card to adjust MT options.Feb 26 2018, 12:45 PM
Pginer-WMF triaged this task as Medium priority.
Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.Mar 1 2018, 4:44 PM
Pginer-WMF raised the priority of this task from Medium to High.Mar 21 2018, 12:09 PM
Pginer-WMF added a project: Language-2018-Apr-June.Mar 28 2018, 9:57 AM
Pginer-WMF removed a project: Language-2018-Jan-Mar.Mar 28 2018, 10:12 AM
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-2018-Apr-June board.Apr 11 2018, 6:59 AM
santhosh claimed this task.Apr 13 2018, 11:10 AM
gerritbot subscribed.Apr 13 2018, 11:10 AM

Change 425953 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] WIP: Machine translation toolbar

https://gerrit.wikimedia.org/r/425953

gerritbot added a project: Patch-For-Review.Apr 13 2018, 11:10 AM
• Petar.petkovic moved this task from Priority backlog to In Progress on the Language-2018-Apr-June board.Apr 13 2018, 1:36 PM
• Petar.petkovic moved this task from In Progress to In Review on the Language-2018-Apr-June board.Apr 17 2018, 7:34 PM
gerritbot added a comment.Apr 23 2018, 9:30 AM

Change 425953 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Machine translation toolbar

https://gerrit.wikimedia.org/r/425953

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 23 2018, 10:00 AM
santhosh moved this task from In Review to In Progress on the Language-2018-Apr-June board.Apr 23 2018, 12:11 PM

https://gerrit.wikimedia.org/r/425953 was first iteration of this ticket. Current status:

  1. On focus of an editable section, MT tool is presented in tools column.
  2. The dropdown is populated by MT engines provided by cxserver
  3. Selecting the options in the dropdowns works, but there is no progress indicator, while the api request is in progress
  4. The results of API request are not remembered. So if the same option is selected more than once, API requests happen more than once
  5. User modifications are not rememberd across selection of MT engines
  6. A small scroll happens between MT engine selection changes
  7. The current MT provider for a section is not remembered when focus returned to a section after navigating through other sections

We need a state object for every sections in its data model(ve.dm.CXSectionNode) and some convinient methods to query them. The state object should store the current MT provider. The caching of user modifications mapped to an MT provider can be either in TranslationController(mapped to sectionId). Or it can be in ve.dm.CXSectionNode itself. We need to know whether the content is unmodified MT or modified MT. The state object should also rememer whether the section was restored or a fresh section.

santhosh reassigned this task from santhosh to Nikerabbit.Apr 26 2018, 6:43 AM
santhosh subscribed.
Nikerabbit removed a project: Patch-For-Review.Apr 26 2018, 7:52 AM
Pginer-WMF updated the task description. (Show Details)May 1 2018, 4:34 PM

I added T193453: CX2: Translation options are not available for some languages as a related ticket in the description, which may be part of the pending work described in T188247#4149455.

Pginer-WMF added a subtask: T193453: CX2: Translation options are not available for some languages.May 1 2018, 4:36 PM
Pginer-WMF updated the task description. (Show Details)May 3 2018, 2:03 PM
Pginer-WMF added a comment.May 3 2018, 2:06 PM

I added T193586: " Uncaught Error: Unbalanced set of replace operations found" appears while switching from option "Automatic Translation" to "Don't use machine translation" as a related ticket since the bug seems connected with the MT card.

Pginer-WMF updated the task description. (Show Details)May 3 2018, 2:07 PM
Nikerabbit mentioned this in T193453: CX2: Translation options are not available for some languages.May 8 2018, 6:41 AM
Etonkovidova closed subtask T193453: CX2: Translation options are not available for some languages as Resolved.May 10 2018, 10:17 PM
gerritbot added a comment.May 14 2018, 6:55 AM

Change 432954 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] CX2: Fix multiple MT related issues

https://gerrit.wikimedia.org/r/432954

gerritbot added a project: Patch-For-Review.May 14 2018, 6:55 AM
gerritbot added a comment.May 15 2018, 10:32 AM

Change 432954 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX2: Fix multiple MT related issues

https://gerrit.wikimedia.org/r/432954

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)); removed MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).May 15 2018, 11:00 AM
• Petar.petkovic removed a project: Patch-For-Review.May 15 2018, 11:07 AM
• Petar.petkovic moved this task from In Progress to QA on the Language-2018-Apr-June board.
gerritbot added a comment.May 19 2018, 3:10 PM

Change 434001 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] CX2: Update selected MT engine status on MT failure

https://gerrit.wikimedia.org/r/434001

gerritbot added a project: Patch-For-Review.May 19 2018, 3:10 PM
gerritbot added a comment.May 19 2018, 4:54 PM

Change 434001 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX2: Update selected MT engine status on MT failure

https://gerrit.wikimedia.org/r/434001

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)); removed MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)).May 19 2018, 5:00 PM
• Petar.petkovic removed a project: Patch-For-Review.May 22 2018, 10:14 AM
gerritbot added a comment.May 28 2018, 2:41 PM

Change 435795 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] CX2: Implement "Set as default" for MT card

https://gerrit.wikimedia.org/r/435795

gerritbot added a project: Patch-For-Review.May 28 2018, 2:41 PM
gerritbot added a comment.May 28 2018, 4:28 PM

Change 435809 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] CX2: Implement "Reset translation" in MT card

https://gerrit.wikimedia.org/r/435809

• Petar.petkovic moved this task from QA to In Review on the Language-2018-Apr-June board.May 29 2018, 7:07 AM
Nikerabbit mentioned this in T195811: CX2: "Reset translation" option in MT card should not be shown all the time.May 29 2018, 8:06 AM
Nikerabbit updated the task description. (Show Details)
gerritbot added a comment.May 29 2018, 10:56 AM

Change 435795 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] CX2: Implement "Set as default" for MT card

https://gerrit.wikimedia.org/r/435795

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)); removed MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)).May 29 2018, 11:01 AM
gerritbot added a comment.May 29 2018, 11:39 AM

Change 435809 merged by Santhosh:
[mediawiki/extensions/ContentTranslation@master] CX2: Implement "Reset translation" in MT card

https://gerrit.wikimedia.org/r/435809

• Petar.petkovic removed a project: Patch-For-Review.May 29 2018, 11:50 AM
• Petar.petkovic moved this task from In Review to QA on the Language-2018-Apr-June board.
Etonkovidova subscribed.May 29 2018, 11:33 PM

@Pginer-WMF - technically, all specs have been implemented and there are no obvious bugs. My comments below are about some observations, so please, take a look to review them.

(1) When a new translation starts - there will be no options to select. Yes, it's true as per @santhosh comment that

On focus of an editable section, MT tool is presented in tools column.

A user will see options only after clicking on a paragraph which starts the translation with the default setting. For a user who wants to use a different translation option, it's an extra step.
Clicking anywhere on the side panel, brings the instructions back, and to bring the translation options back, a user needs to figure out somehow to click in the paragraph.

(2) If a user selects one option and later changes his/her mind and switches to a different option - the helpful grey box "+ Add translation" (along with the highlighting of a source paragraph) won't be present anymore.

Although switching between options works perfectly, it's not intuitive to figure out at this point that other translation options will work.

(3) When I click "Keep as default", there is no indication to a user that the specific option is, in fact, set as default. Only when I open the drop down list of options, then I'll see that the default option is highlighted.

(4) If I select 'Don't use machine translation", "+ Add paragraph" still be displayed and, as soon as I clicked on it, it changes to "+ Insert paragraph" - these both indications are not necessary since they do not do anything when clicked.

(5) Why there are two different failure messages?

Screen Shot 2018-05-29 at 3.53.49 PM.png (357×429 px, 24 KB)

Screen Shot 2018-05-28 at 1.33.17 PM.png (242×374 px, 16 KB)

Pginer-WMF mentioned this in T196051: CX2: Show reset option in the MT card only when the paragraph has been modified.May 31 2018, 9:32 AM
Pginer-WMF mentioned this in T196056: CX2: Focus on the empty paragraph after "no MT" option is selected.May 31 2018, 9:46 AM
Pginer-WMF mentioned this in T196060: CX2: Better communicate waiting and application of MT when changed.May 31 2018, 10:45 AM
Pginer-WMF mentioned this in T196065: CX2: Better communicate the default status in the Automatic Translation card.May 31 2018, 11:43 AM

Thanks for the input @Etonkovidova, I created some tickets as follow-up improvements based on your comments:

Related to when to show the card, I don't think it is needed to configure it in advance. Getting an initial example of what MT is after adding a paragraph helps to illustrate the purpose of the card. In addition, the default service is likely to be the best choice in many cases.

Etonkovidova closed this task as Resolved.May 31 2018, 5:37 PM

Thanks, @Pginer-WMF - the follow up tickets cover sufficiently some improvements in usability. I am closing this task since no direct outstanding issues/bugs are found.

Pginer-WMF added a comment.Jun 1 2018, 7:13 AM

Another issue that may be related to this ares is T196136: CX2: Failure in MT eliminates the paragraph and breaks alignment

• Petar.petkovic moved this task from QA to Done on the Language-2018-Apr-June board.Jun 3 2018, 9:49 PM
Pginer-WMF mentioned this in T197688: CX2: Control whether references are translated or not.Jun 19 2018, 2:29 PM
• Vvjjkkii reopened subtask T193453: CX2: Translation options are not available for some languages as Open.Jul 1 2018, 1:12 AM
Arrbee closed subtask T193453: CX2: Translation options are not available for some languages as Resolved.Jul 2 2018, 1:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits