[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-man
Subject:    Re: [PATCH] MAN: Clarify mremap.2 prototype
From:       Michael Kerrisk <mtk.manpages () googlemail ! com>
Date:       2010-06-11 14:34:33
Message-ID: AANLkTin1Hdqhrza-rDiRAfZ5q7AquQ8zYOBzyaUc1FC0 () mail ! gmail ! com
[Download RAW message or body]

Andi,

On Fri, Jun 11, 2010 at 10:38 AM, Andi Kleen <[email protected]> wrote:
>> > This change will give less information to the reader than the patch. It doesn't
>> > seem like a improvement to me.
>>
>> It gives less information than your patch, because your patch repeated
>> information that was already in the page.
>
> The correct prototype for the 5 argument option was and is still missing.
> Text is no replacement for a correct prototype.

What I want to avoid is cluttering the page with multiple prototypes.
(If we went that way, then pages like fcntl(2) could get rather
messy.) But, to try to alleviate your concern, I modified the patch
somewhat. Hopefully, this will satisfy you.

Cheers,

Michael

--- a/man2/mremap.2
+++ b/man2/mremap.2
@@ -38,7 +38,7 @@ mremap \- remap a virtual memory address
 .B #include <sys/mman.h>
 .sp
 .BI "void *mremap(void *" old_address ", size_t " old_size ,
-.BI "             size_t " new_size ", int " flags );
+.BI "             size_t " new_size ", int " flags ", ... /* void *"
new_address " */);"
 .fi
 .SH DESCRIPTION
 .BR mremap ()
@@ -54,6 +54,11 @@ aligned.
 virtual memory block.
 \fInew_size\fP is the requested size of the
 virtual memory block after the resize.
+An optional fifth argument,
+.IR new_address ,
+may be provided; see the description of
+.B MREMAP_FIXED
+below.

 In Linux the memory is divided into pages.
 A user process has (one or)
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]