Re: [PATCH] brcmfmac: added LED triggers for transmit/receive

[Russell Joyce]

> 1) I think most of it should be some cfg80211 shareable code.

Iâm not sure exactly what you mean by this, could you please clarify?

> 2) This "rxtx" while surely present in other places sounds like a
> workaround for LED subsystem limitation. Maybe it's time to finally
> rework LED triggers.

I agree that itâs not an ideal way to do things, but I couldnât think of a
better alternative. I think that having a combined trigger is useful though, for
situations like using the single LED on a Raspberry Pi to show Wi-Fi activity.


> On 10 Jul 2017, at 10:48, RafaÅ MiÅecki <zajec5@xxxxxxxxx> wrote:
> 
> On 7 July 2017 at 16:09, Russell Joyce <russell.joyce@xxxxxxxxxx> wrote:
>> Add three basic LED triggers to brcmfmac, based on those in mac80211: one
>> for transmit, one for receive, and one for combined transmit/receive.
>> 
>> Signed-off-by: Russell Joyce <russell.joyce@xxxxxxxxxx>
> 
> 1) I think most of it should be some cfg80211 shareable code.
> 2) This "rxtx" while surely present in other places sounds like a
> workaround for LED subsystem limitation. Maybe it's time to finally
> rework LED triggers.