[LTP] [PATCH] syscalls/fanotify10: Make evictable marks test more reliable

Sat Aug 27 19:42:35 CEST 2022

> On Sat, Aug 27, 2022 at 1:09 AM Petr Vorel <[email protected]> wrote:

> > > On Fri, Aug 26, 2022 at 5:19 PM Jan Kara <[email protected]> wrote:

> > > > On Fri 26-08-22 15:12:14, Petr Vorel wrote:
> > > > > Hi Jan, all,

> > > > > > In some setups evictable marks tests are failing because the inode with
> > > > > > evictable mark does not get evicted. Make sure we sync the filesystem
> > > > > > before we try to drop caches to increase likelyhood the inode will get
> > > > > > evicted.

> > > > > Merged with minor changes to keep checkpatch.pl happy.

> > > > Thanks!

> > > > > Given on previous discussion the behavior on ext2 vs. xfs:
> > > > > would it make sense to transform the test to use .all_filesystems = 1 ?

> > > On the contrary.
> > > We want the inode reclaim to be as predictable as possible.
> > > That is why I suggested to force the test to use ext2
> > > because xfs has some specialized inode reclaim

> > Ah right! Could you please send a patch with .dev_fs_type = "ext2"
> > That should be enough I guess.

> Petr, I don't think there is a need for that.
> I was only pointing out the different fs can have different inode
> reclaim behaviors.
> I had not encountered issues when testing fanotify10 on xfs myself.

> Jan's patch should be enough and then the test can run
> on the user's choice of filesystem, which is always better than
> unneeded restrictions.

> If we see issues on xfs we can reconsider .dev_fs_type = "ext2".

Amir, thanks for explanation. Makes sense.

Kind regards,
Petr

> Thanks,
> Amir.