Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net9.0] [msbuild] Improve the error message when the SupportedOSPlatformVersion is lower than the minimum. Fixes #21368. (#21369) #21413

Merged
merged 2 commits into from
Oct 11, 2024
Merged

[net9.0] [msbuild] Improve the error message when the SupportedOSPlatformVersion is lower than the minimum. Fixes #21368. (#21369) #21413

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d1cfd6
[net9.0] [msbuild] Improve the error message when the SupportedOSPlat…
rolfbjarne Oct 10, 2024
b0d6ac4
Fix generator tests.
rolfbjarne Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix generator tests.
  • Loading branch information
@rolfbjarne
rolfbjarne committed Oct 11, 2024
commit b0d6ac47dcd2ff08b422d826aa40e7e986097dca
2 changes: 1 addition & 1 deletion tests/generator/BGenTool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ public static void AddPreviewNoWarn (IList<string> argumentList)
public static string? GetPreviewNoWarn (string? existingNowarn)
{
if (Configuration.XcodeIsStable)
return null;
return existingNowarn;

var previewNoWarn = $"XCODE_{Configuration.XcodeVersion.Major}_{Configuration.XcodeVersion.Minor}_PREVIEW";
if (string.IsNullOrEmpty (existingNowarn)) {
Expand Down