Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools] Improve logging/reporting when running into problems with binding projects / assemblies. #18683

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix typo
  • Loading branch information
rolfbjarne committed Aug 10, 2023
commit 75218ea7bfc7bf57e535c72e70f7bc48ce0dfc24
2 changes: 1 addition & 1 deletion tools/common/Assembly.cs
Original file line number Diff line number Diff line change
@@ -293,7 +293,7 @@ void ProcessLinkWithAttributes (AssemblyDefinition assembly)
break;
default: {
// TryExtractFramework prints a error/warning if something goes wrong, so no need for us to have an error handling path.
if (TryExtractFramework (assembly, metadata, out var framework))
if (TryExtractNativeLibrary (assembly, metadata, out var framework))
LinkWith.Add (framework);
break;
}